Summary: | CGI::escapeHTML should not be used anymore | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, hector.hecaxmmx, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15754 | ||
Bug Blocks: | |||
Attachments: |
Bug 15771: Do not use CGI::escapeHTML anymore
[SIGNED-OFF]Bug 15771: Do not use CGI::escapeHTML anymore |
Description
Jonathan Druart
2016-02-09 15:41:10 UTC
Created attachment 47813 [details] [review] Bug 15771: Do not use CGI::escapeHTML anymore In admin/auth_subfields_structure.pl, admin/marc_subfields_structure.pl and catalogue/image.pl, the pl script escapes html characters. Since bug 13618 has been pushed, this method should not be used anymore. Test plan: 1/ Edit a framework (biblio and authority) 2/ In the "text for librarian" input, fill "test'apostrophe" 3/ Save 4/ Edit subfields => Without this patch, the ' is displayed escaped => With this patch, everything is fine Created attachment 47822 [details] [review] [SIGNED-OFF]Bug 15771: Do not use CGI::escapeHTML anymore In admin/auth_subfields_structure.pl, admin/marc_subfields_structure.pl and catalogue/image.pl, the pl script escapes html characters. Since bug 13618 has been pushed, this method should not be used anymore. Test plan: 1/ Edit a framework (biblio and authority) 2/ In the "text for librarian" input, fill "test'apostrophe" 3/ Save 4/ Edit subfields => Without this patch, the ' is displayed escaped => With this patch, everything is fine Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Need to change status of this report after reverting 13618 ? |