Bug 15771 - CGI::escapeHTML should not be used anymore
Summary: CGI::escapeHTML should not be used anymore
Status: RESOLVED DUPLICATE of bug 15773
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 15754
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-09 15:41 UTC by Jonathan Druart
Modified: 2018-06-20 15:50 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15771: Do not use CGI::escapeHTML anymore (4.32 KB, patch)
2016-02-09 15:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15771: Do not use CGI::escapeHTML anymore (4.42 KB, patch)
2016-02-09 17:15 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-02-09 15:41:10 UTC
In admin/auth_subfields_structure.pl, admin/marc_subfields_structure.pl and catalogue/image.pl, the pl script escapes html characters.
Since bug 13618 has been pushed, this method should not be used anymore.
Comment 1 Jonathan Druart 2016-02-09 15:42:56 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-02-09 17:15:20 UTC
Created attachment 47822 [details] [review]
[SIGNED-OFF]Bug 15771: Do not use CGI::escapeHTML anymore

In admin/auth_subfields_structure.pl, admin/marc_subfields_structure.pl
and catalogue/image.pl, the pl script escapes html characters.
Since bug 13618 has been pushed, this method should not be used anymore.

Test plan:
1/ Edit a framework (biblio and authority)
2/ In the "text for librarian" input, fill "test'apostrophe"
3/ Save
4/ Edit subfields
=> Without this patch, the ' is displayed escaped
=> With this patch, everything is fine

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised
Comment 3 Marcel de Rooy 2016-02-12 07:38:39 UTC
Need to change status of this report after reverting 13618 ?
Comment 4 Jonathan Druart 2018-06-20 15:50:22 UTC
Occurrences of CGI::escapeHTML have been removed by bug 15773.

*** This bug has been marked as a duplicate of bug 15773 ***