|
Description
Owen Leonard
2016-02-10 16:22:00 UTC
Created attachment 47858 [details] [review] Bug 15784 - Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Created attachment 47867 [details] [review] [SIGNED-OFF]Bug 15784: Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Created attachment 47976 [details] [review] Bug 15784 [Revised] Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 47977 [details] [review] Bug 15784 [Revised] Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 47987 [details] [review] Bug 15784: Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 47989 [details] [review] Bug 15784: Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 Release. Thanks Created attachment 48734 [details] [review] [3.22.x] Bug 15784: Library deletion warning is incorrectly styled Patch for 3.22.x Patch pushed to 3.22.x, will be in 3.22.5 This patch has been pushed to 3.20.x, will be in 3.20.10. |