Bug 16092 - Fix error dialog and use Font Awesome Icons when deleting branch group
Summary: Fix error dialog and use Font Awesome Icons when deleting branch group
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Héctor Eduardo Castro Avalos
QA Contact: Testopia
URL:
Keywords:
Depends on: 16047
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-17 16:24 UTC by Héctor Eduardo Castro Avalos
Modified: 2016-12-05 21:27 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16092: Introduce the Font Awesome icons when delete a branch category. (5.80 KB, patch)
2016-03-17 16:41 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16092: Introduce the Font Awesome icons when delete a branch category. (5.93 KB, patch)
2016-03-17 16:57 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a branch category (6.05 KB, patch)
2016-03-29 15:01 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a branch category (6.02 KB, patch)
2016-03-29 15:08 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a branch category (6.09 KB, patch)
2016-03-31 12:36 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Héctor Eduardo Castro Avalos 2016-03-17 16:24:15 UTC
Found when signed-off bug 16091.

Introduce the Font Awesome icons when delete a branch category.

Also change admin/branch.pl   type => 'error' to type => 'alert' to fit with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages>
Comment 1 Héctor Eduardo Castro Avalos 2016-03-17 16:41:12 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-03-17 16:57:47 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2016-03-18 17:34:37 UTC
Still applies without DUPLICATE BUG 16091, the patch applies in both ways applying on top 16047 only or applying 16047 and 16015 on top.

>Using index info to reconstruct a base tree...
>Falling back to patching base and 3-way merge...
>Auto-merging admin/branches.pl
Comment 4 Katrin Fischer 2016-03-20 22:02:03 UTC
Sorry, but this no longer applies:
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 16092: Introduce the Font Awesome icons when delete a branch category.
fatal: sha1 information is lacking or useless (admin/branches.pl).

The patch code also seems to include a lot more than the Font Awesome icon change - please correct bug title to reflect this :)
Comment 5 Héctor Eduardo Castro Avalos 2016-03-29 15:01:57 UTC Comment hidden (obsolete)
Comment 6 Héctor Eduardo Castro Avalos 2016-03-29 15:08:14 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2016-03-31 12:36:36 UTC
Created attachment 49733 [details] [review]
Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a branch category

Also change admin/branch.pl   type => 'error' to type => 'alert' to fit
with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages>

To test:
1) Go to Admin -> Libraries and groups
2) Try to delete a library with patrons and bib items
3) See the error message in yellow
4) Try to delete a branch category/group without any library attached
   to it
5) Apply patch and repeat steps 1 to 4. Notice about the changes
6) Test buttons Yes, delete and No, do not delete and verify that they
   work as expected

Signed-off-by: Marc Véron <veron@veron.ch>

NOTE: Patch rebased and reword title according with QA comment 4

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Brendan Gallagher 2016-03-31 19:39:26 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!