|
Description
Liz Rea
2016-02-10 21:50:32 UTC
Created attachment 47938 [details] [review] Bug 15793: Add floating toolbar to circulation.tt To test: 1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a') 2) Confirm 'Select patron' button is now at the top 3) Scroll down page, confirm button toolbar follows you down the page 4) Select a patron and click button - confirm you are taken to the correct patron page Created attachment 47940 [details] [review] Bug 15793: Add floating toolbar to circulation.tt To test: 1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a') 2) Confirm 'Select patron' button is now at the top 3) Scroll down page, confirm button toolbar follows you down the page 4) Select a patron and click button - confirm you are taken to the correct patron page Signed-off-by: Liz Rea <liz@catalyst.net.nz> This is much nicer, thank you. :) Status is still 'Needs Signoff' - should it be switched to SO? Created attachment 47992 [details] [review] Bug 15793 - UX of circulation patron search with long lists of returned borrowers Using form controls to select a patron from the list of patron search results during checkout means that we have to have a submit button somewhere on a potentially very long form. This patch proposes that we use links to the patron records instead. This patch also makes a minor correction to the template to allow for the correct layout grid to be used, and enables the display of full library names in search results instead of branchcode. To test, apply the patch and search for a patron name from the "Check out" form in the header. Clicking the name of any patron in the search results should take you to the correct checkout page. Sorry, I don't mean to be a busybody and I certainly appreciate Aleisha's work to come up with a good solution for this. I just want to push it a little further and see if we can simplify even more. Is there a reason not to use a link here? The method of using form submission includes a lot of hidden fields, but are they used? There are other places in Koha where a checkout is initiated using a plain link, so my assumption is that those hidden fields aren't necessary. We did think about having every name as a link and just thought a floating toolbar could be cool! Up to whoever signs off and QAs to see which they like best since either works :) I'm not fussy either way either, I'm happy as long as the problem of "I have to scroll for pages and pages to get to the submit button" is solved. :) Liz Created attachment 49457 [details] [review] Bug 15793 - UX of circulation patron search with long lists of returned borrowers Using form controls to select a patron from the list of patron search results during checkout means that we have to have a submit button somewhere on a potentially very long form. This patch proposes that we use links to the patron records instead. This patch also makes a minor correction to the template to allow for the correct layout grid to be used, and enables the display of full library names in search results instead of branchcode. To test, apply the patch and search for a patron name from the "Check out" form in the header. Clicking the name of any patron in the search results should take you to the correct checkout page. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> I prefer the simpler solution Owen provided and signed off on it. What do others think? (In reply to Mirko Tietgen from comment #9) > I prefer the simpler solution Owen provided and signed off on it. What do > others think? +1 Could we have something between the two? :) It could be easier to have the tr clickable instead of clicking on a link. Created attachment 49472 [details] [review] Bug 15793 - UX of circulation patron search with long lists of returned borrowers Okay how about this: This patch has no floating toolbar or names styled as links. I've removed the radio buttons. The row is clickable and will redirect you to the user's page. To test: 1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a') 2) Select a patron by clicking anywhere on the row - confirm you are taken to the correct patron page Sponsored-by: Catalyst IT (In reply to Aleisha Amohia from comment #12) > Created attachment 49472 [details] [review] [review] > Bug 15793 - UX of circulation patron search with long lists of returned > borrowers > > Okay how about this: > This patch has no floating toolbar or names styled as links. I've removed > the radio buttons. The row is clickable and will redirect you to the user's > page. > > To test: > 1) Put in a patron search that will bring back a long list of patrons (ie > the letter 'a') > 2) Select a patron by clicking anywhere on the row - confirm you are taken > to the correct patron page > > Sponsored-by: Catalyst IT Looks fine. Clickable row is the most ergonomic solution (patch 47940 + patch 449472 applied). Created attachment 49520 [details] [review] Bug 15793: Add floating toolbar to circulation.tt To test: 1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a') 2) Confirm 'Select patron' button is now at the top 3) Scroll down page, confirm button toolbar follows you down the page 4) Select a patron and click button - confirm you are taken to the correct patron page Signed-off-by: Liz Rea <liz@catalyst.net.nz> This is much nicer, thank you. :) Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49521 [details] [review] Bug 15793 - UX of circulation patron search with long lists of returned borrowers Okay how about this: This patch has no floating toolbar or names styled as links. I've removed the radio buttons. The row is clickable and will redirect you to the user's page. To test: 1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a') 2) Select a patron by clicking anywhere on the row - confirm you are taken to the correct patron page Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Signed off on the two patches. Strange, while attaching the sign-offs, the alternate patch from Owen Leonard, was obsoleted as well (2016-03-23 18:10 UTC, signed-off by Mirko Tietgen, 4th patch if you show obsoleted ones). Maybe because of the same title? Leaving it obsoleted at the moment. (In reply to Aleisha Amohia from comment #12) > This patch has no floating toolbar or names styled as links. I've removed > the radio buttons. The row is clickable and will redirect you to the user's > page. I strongly disagree with this solution. There is no indication at all, now, that the user can perform any action. Nothing looks like a link and the mouse cursor doesn't change to indicate anything is clickable. (In reply to Owen Leonard from comment #17) > (In reply to Aleisha Amohia from comment #12) > > This patch has no floating toolbar or names styled as links. I've removed > > the radio buttons. The row is clickable and will redirect you to the user's > > page. > > I strongly disagree with this solution. There is no indication at all, now, > that the user can perform any action. Nothing looks like a link and the > mouse cursor doesn't change to indicate anything is clickable. Does the solution work for you if we change the cursor? Created attachment 49611 [details] [review] Bug 15793 - UX of circulation patron search with long lists of returned borrowers Okay how about this: This patch has no floating toolbar or names styled as links. I've removed the radio buttons. The row is clickable and will redirect you to the user's page. EDIT: This patch makes the cursor a pointer when hovering over the patrons. The row will also be highlighted on hover to make it even clearer. To test: 1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a') 2) Select a patron by clicking anywhere on the row - confirm you are taken to the correct patron page Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> (In reply to Aleisha Amohia from comment #19) (...) > > EDIT: This patch makes the cursor a pointer when hovering over the patrons. > The row will also be highlighted on hover to make it even clearer. (...) Looks OK for me. Hi, Overall I like this - one small thing, if you click the "select" button at the bottom it will say "borrower not found." I feel we should omit it. Owen? What do you think? Liz Created attachment 49655 [details] [review] Bug 15793 - UX of circulation patron search with long lists of returned borrowers Okay how about this: This patch has no floating toolbar or names styled as links. I've removed the radio buttons. The row is clickable and will redirect you to the user's page. EDIT: This patch makes the cursor a pointer when hovering over the patrons. The row will also be highlighted on hover to make it even clearer. EDIT2: Removes unnecessary 'Select' button To test: 1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a') 2) Select a patron by clicking anywhere on the row - confirm you are taken to the correct patron page Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49656 [details] [review] Bug 15793 - UX of circulation patron search with long lists of returned borrowers Okay how about this: This patch has no floating toolbar or names styled as links. I've removed the radio buttons. The row is clickable and will redirect you to the user's page. EDIT: This patch makes the cursor a pointer when hovering over the patrons. The row will also be highlighted on hover to make it even clearer. EDIT2: Removes unnecessary 'Select' button To test: 1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a') 2) Select a patron by clicking anywhere on the row - confirm you are taken to the correct patron page Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Liz Rea <liz@catalyst.net.nz> Submit button removed, patron selection on this screen much better for long lists (and short ones as well.) As far as I can tell, this bug has one patch signed off by both Marc and Liz. Updating status accordingly. Please set back to NSO if I missed something. Created attachment 49734 [details] [review] Bug 15793 - UX of circulation patron search with long lists of returned borrowers Okay how about this: This patch has no floating toolbar or names styled as links. I've removed the radio buttons. The row is clickable and will redirect you to the user's page. EDIT: This patch makes the cursor a pointer when hovering over the patrons. The row will also be highlighted on hover to make it even clearer. EDIT2: Removes unnecessary 'Select' button To test: 1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a') 2) Select a patron by clicking anywhere on the row - confirm you are taken to the correct patron page Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Liz Rea <liz@catalyst.net.nz> Submit button removed, patron selection on this screen much better for long lists (and short ones as well.) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! |