Bug 15902

Summary: Remove use of recordpayment in process_koc.pl
Product: Koha Reporter: Kyle M Hall <kyle>
Component: Architecture, internals, and plumbingAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, mirko, veron
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15895    
Bug Blocks: 15899    
Attachments: Bug 15902 - Remove use of recordpayment in process_koc.pl
Bug 15902 - Remove use of recordpayment in process_koc.pl
Bug 15902 - Remove use of recordpayment in process_koc.pl
Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers
Bug 15902 - Remove use of recordpayment in process_koc.pl
Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers
Bug 15902 - Remove use of recordpayment in process_koc.pl
Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers

Description Kyle M Hall 2016-02-24 15:31:22 UTC

    
Comment 1 Kyle M Hall 2016-02-24 15:32:14 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2016-03-25 07:59:57 UTC
Adding the payment to the queue and then processing it works.

Applying the payment directly does not work. Firebug shows a call to jquery.js over and over again.

> http://192.168.2.11:8080/cgi-bin/koha/tools/background-job-progress.pl?jobID=1f05eb29131838b2ce1466eed03feebc
Comment 3 Kyle M Hall 2016-04-19 10:43:14 UTC
(In reply to Mirko Tietgen from comment #2)
> Adding the payment to the queue and then processing it works.
> 
> Applying the payment directly does not work. Firebug shows a call to
> jquery.js over and over again.

I was unable to replicate your issue. I was able to apply the payment both via the queue and directly with no issues!
Comment 4 Kyle M Hall 2016-06-07 15:11:38 UTC Comment hidden (obsolete)
Comment 5 Josef Moravec 2016-08-23 09:25:24 UTC
Created attachment 54748 [details] [review]
Bug 15902 - Remove use of recordpayment in process_koc.pl

Test plan:
1) Apply this patch
2) Create an offline circ payment
3) Process the offline circ payment
4) Payment should show in Koha

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 6 Jonathan Druart 2016-08-23 11:23:26 UTC
 FAIL   offline_circ/process_koc.pl
   FAIL   forbidden patterns
                forbidden pattern: Koha::Borrower has been moved by bug 15548 (line 367)
Comment 7 Kyle M Hall 2016-09-06 15:05:32 UTC
Created attachment 55260 [details] [review]
Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers

Since the initial submission of this patch, the module Koha::Borrowers
has been moved to Koha::Patrons. This patch changes the call from
Koha::Borrowers to Koha::Patrons.
Comment 8 Jonathan Druart 2016-09-28 11:09:07 UTC
Created attachment 55875 [details] [review]
Bug 15902 - Remove use of recordpayment in process_koc.pl

Test plan:
1) Apply this patch
2) Create an offline circ payment
3) Process the offline circ payment
4) Payment should show in Koha

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 9 Jonathan Druart 2016-09-28 11:09:13 UTC
Created attachment 55876 [details] [review]
Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers

Since the initial submission of this patch, the module Koha::Borrowers
has been moved to Koha::Patrons. This patch changes the call from
Koha::Borrowers to Koha::Patrons.
Comment 10 Jonathan Druart 2016-09-28 11:11:15 UTC
Created attachment 55880 [details] [review]
Bug 15902 - Remove use of recordpayment in process_koc.pl

Test plan:
1) Apply this patch
2) Create an offline circ payment
3) Process the offline circ payment
4) Payment should show in Koha

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Jonathan Druart 2016-09-28 11:11:19 UTC
Created attachment 55881 [details] [review]
Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers

Since the initial submission of this patch, the module Koha::Borrowers
has been moved to Koha::Patrons. This patch changes the call from
Koha::Borrowers to Koha::Patrons.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 12 Kyle M Hall 2016-09-29 11:17:13 UTC
Pushed to master for 16.11!