Created attachment 48339 [details] [review] Bug 15902 - Remove use of recordpayment in process_koc.pl Test plan: 1) Apply this patch 2) Create an offline circ payment 3) Process the offline circ payment 4) Payment should show in Koha
Adding the payment to the queue and then processing it works. Applying the payment directly does not work. Firebug shows a call to jquery.js over and over again. > http://192.168.2.11:8080/cgi-bin/koha/tools/background-job-progress.pl?jobID=1f05eb29131838b2ce1466eed03feebc
(In reply to Mirko Tietgen from comment #2) > Adding the payment to the queue and then processing it works. > > Applying the payment directly does not work. Firebug shows a call to > jquery.js over and over again. I was unable to replicate your issue. I was able to apply the payment both via the queue and directly with no issues!
Created attachment 52144 [details] [review] Bug 15902 - Remove use of recordpayment in process_koc.pl Test plan: 1) Apply this patch 2) Create an offline circ payment 3) Process the offline circ payment 4) Payment should show in Koha
Created attachment 54748 [details] [review] Bug 15902 - Remove use of recordpayment in process_koc.pl Test plan: 1) Apply this patch 2) Create an offline circ payment 3) Process the offline circ payment 4) Payment should show in Koha Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
FAIL offline_circ/process_koc.pl FAIL forbidden patterns forbidden pattern: Koha::Borrower has been moved by bug 15548 (line 367)
Created attachment 55260 [details] [review] Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers Since the initial submission of this patch, the module Koha::Borrowers has been moved to Koha::Patrons. This patch changes the call from Koha::Borrowers to Koha::Patrons.
Created attachment 55875 [details] [review] Bug 15902 - Remove use of recordpayment in process_koc.pl Test plan: 1) Apply this patch 2) Create an offline circ payment 3) Process the offline circ payment 4) Payment should show in Koha Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 55876 [details] [review] Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers Since the initial submission of this patch, the module Koha::Borrowers has been moved to Koha::Patrons. This patch changes the call from Koha::Borrowers to Koha::Patrons.
Created attachment 55880 [details] [review] Bug 15902 - Remove use of recordpayment in process_koc.pl Test plan: 1) Apply this patch 2) Create an offline circ payment 3) Process the offline circ payment 4) Payment should show in Koha Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 55881 [details] [review] Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers Since the initial submission of this patch, the module Koha::Borrowers has been moved to Koha::Patrons. This patch changes the call from Koha::Borrowers to Koha::Patrons. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11!