Summary: | SIPILS.t should be moved to t/db_dependent | ||
---|---|---|---|
Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
Component: | Test Suite | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, julian.maurice, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 15956 | ||
Attachments: |
Bug 15947: move SIPILS.t to DB-dependent test directory
[SIGNED OFF] Bug 15947: move SIPILS.t to DB-dependent test directory Bug 15947: move SIPILS.t to DB-dependent test directory |
Description
Galen Charlton
2016-03-01 13:51:04 UTC
Created attachment 48511 [details] [review] Bug 15947: move SIPILS.t to DB-dependent test directory SIPILS.t requires an active koha-conf.xml to pass, and consequently is moved to t/db_dependent so that 'make test' can succeed. To test ------- [1] Unset KOHA_CONF and either do a make test or a prove -v t/SIPILS.t. Note that the tests fail. [2] Apply the patch and run make test again; this time, the test suite should pass. [3] Verify that with KOHA_CONF *set*, prove -v t/db_dependent/SIPILS.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Created attachment 48524 [details] [review] [SIGNED OFF] Bug 15947: move SIPILS.t to DB-dependent test directory SIPILS.t requires an active koha-conf.xml to pass, and consequently is moved to t/db_dependent so that 'make test' can succeed. To test ------- [1] Unset KOHA_CONF and either do a make test or a prove -v t/SIPILS.t. Note that the tests fail. [2] Apply the patch and run make test again; this time, the test suite should pass. [3] Verify that with KOHA_CONF *set*, prove -v t/db_dependent/SIPILS.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 48538 [details] [review] Bug 15947: move SIPILS.t to DB-dependent test directory SIPILS.t requires an active koha-conf.xml to pass, and consequently is moved to t/db_dependent so that 'make test' can succeed. To test ------- [1] Unset KOHA_CONF and either do a make test or a prove -v t/SIPILS.t. Note that the tests fail. [2] Apply the patch and run make test again; this time, the test suite should pass. [3] Verify that with KOHA_CONF *set*, prove -v t/db_dependent/SIPILS.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to Master - should be in the May 2016 Release. Thanks! Patch pushed to 3.22.x, will be in 3.22.5 |