Bug 15947

Summary: SIPILS.t should be moved to t/db_dependent
Product: Koha Reporter: Galen Charlton <gmcharlt>
Component: Test SuiteAssignee: Galen Charlton <gmcharlt>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: brendan, julian.maurice, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 15956    
Attachments: Bug 15947: move SIPILS.t to DB-dependent test directory
[SIGNED OFF] Bug 15947: move SIPILS.t to DB-dependent test directory
Bug 15947: move SIPILS.t to DB-dependent test directory

Description Galen Charlton 2016-03-01 13:51:04 UTC
t/SIPILS.t, which was added in bug 15479, requires an active koha-conf.xml to pass, and consequently should be moved to t/db_dependent.  This required patching around in order to build the 3.22.4 Debian packages.
Comment 1 Galen Charlton 2016-03-01 13:55:24 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2016-03-01 22:50:41 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2016-03-02 07:32:01 UTC
Created attachment 48538 [details] [review]
Bug 15947: move SIPILS.t to DB-dependent test directory

SIPILS.t requires an active koha-conf.xml to pass,
and consequently is moved to t/db_dependent so that
'make test' can succeed.

To test
-------
[1] Unset KOHA_CONF and either do a make test or a
    prove -v t/SIPILS.t.  Note that the tests fail.
[2] Apply the patch and run make test again; this time,
    the test suite should pass.
[3] Verify that with KOHA_CONF *set*,
    prove -v t/db_dependent/SIPILS.t passes.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2016-03-02 12:39:29 UTC
Will add a follow-up under new report: bug 15956.
Comment 5 Brendan Gallagher 2016-03-02 22:03:05 UTC
Pushed to Master - should be in the May 2016 Release.  Thanks!
Comment 6 Julian Maurice 2016-03-07 10:37:09 UTC
Patch pushed to 3.22.x, will be in 3.22.5