t/SIPILS.t, which was added in bug 15479, requires an active koha-conf.xml to pass, and consequently should be moved to t/db_dependent. This required patching around in order to build the 3.22.4 Debian packages.
Created attachment 48511 [details] [review] Bug 15947: move SIPILS.t to DB-dependent test directory SIPILS.t requires an active koha-conf.xml to pass, and consequently is moved to t/db_dependent so that 'make test' can succeed. To test ------- [1] Unset KOHA_CONF and either do a make test or a prove -v t/SIPILS.t. Note that the tests fail. [2] Apply the patch and run make test again; this time, the test suite should pass. [3] Verify that with KOHA_CONF *set*, prove -v t/db_dependent/SIPILS.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Created attachment 48524 [details] [review] [SIGNED OFF] Bug 15947: move SIPILS.t to DB-dependent test directory SIPILS.t requires an active koha-conf.xml to pass, and consequently is moved to t/db_dependent so that 'make test' can succeed. To test ------- [1] Unset KOHA_CONF and either do a make test or a prove -v t/SIPILS.t. Note that the tests fail. [2] Apply the patch and run make test again; this time, the test suite should pass. [3] Verify that with KOHA_CONF *set*, prove -v t/db_dependent/SIPILS.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 48538 [details] [review] Bug 15947: move SIPILS.t to DB-dependent test directory SIPILS.t requires an active koha-conf.xml to pass, and consequently is moved to t/db_dependent so that 'make test' can succeed. To test ------- [1] Unset KOHA_CONF and either do a make test or a prove -v t/SIPILS.t. Note that the tests fail. [2] Apply the patch and run make test again; this time, the test suite should pass. [3] Verify that with KOHA_CONF *set*, prove -v t/db_dependent/SIPILS.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Will add a follow-up under new report: bug 15956.
Pushed to Master - should be in the May 2016 Release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.5