Bug 15947 - SIPILS.t should be moved to t/db_dependent
Summary: SIPILS.t should be moved to t/db_dependent
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Galen Charlton
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 15956
  Show dependency treegraph
 
Reported: 2016-03-01 13:51 UTC by Galen Charlton
Modified: 2017-06-14 22:10 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15947: move SIPILS.t to DB-dependent test directory (967 bytes, patch)
2016-03-01 13:55 UTC, Galen Charlton
Details | Diff | Splinter Review
[SIGNED OFF] Bug 15947: move SIPILS.t to DB-dependent test directory (1.01 KB, patch)
2016-03-01 22:50 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 15947: move SIPILS.t to DB-dependent test directory (1.10 KB, patch)
2016-03-02 07:32 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2016-03-01 13:51:04 UTC
t/SIPILS.t, which was added in bug 15479, requires an active koha-conf.xml to pass, and consequently should be moved to t/db_dependent.  This required patching around in order to build the 3.22.4 Debian packages.
Comment 1 Galen Charlton 2016-03-01 13:55:24 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2016-03-01 22:50:41 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2016-03-02 07:32:01 UTC
Created attachment 48538 [details] [review]
Bug 15947: move SIPILS.t to DB-dependent test directory

SIPILS.t requires an active koha-conf.xml to pass,
and consequently is moved to t/db_dependent so that
'make test' can succeed.

To test
-------
[1] Unset KOHA_CONF and either do a make test or a
    prove -v t/SIPILS.t.  Note that the tests fail.
[2] Apply the patch and run make test again; this time,
    the test suite should pass.
[3] Verify that with KOHA_CONF *set*,
    prove -v t/db_dependent/SIPILS.t passes.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2016-03-02 12:39:29 UTC
Will add a follow-up under new report: bug 15956.
Comment 5 Brendan Gallagher 2016-03-02 22:03:05 UTC
Pushed to Master - should be in the May 2016 Release.  Thanks!
Comment 6 Julian Maurice 2016-03-07 10:37:09 UTC
Patch pushed to 3.22.x, will be in 3.22.5