|
Description
Aleisha Amohia
2016-03-01 23:11:51 UTC
Created attachment 48529 [details] [review] Bug 15952: Moving cataloging search actions into a drop-down menu To test: 1) Go to Cataloging and do a search in the catalog and reservoir (cataloguing/addbooks.pl) 2) Confirm that for the results found in catalog, the options (MARC and Card preview, Edit biblio, Add/edit items) are there and behave as expected. 3) Confirm that for the results found in reservoir, the options (MARC and Card preview, Add biblio) are there and behave as expected. 4) Set user permissions so that the user cannot edit the catalog or items. (editcatalogue -> edit_catalogue and edit_items) 5) Confirm that you no longer see the options to edit or add items/biblio in either table. Sponsored-by: Catalyst IT Created attachment 48537 [details] [review] Bug 15952: Moving cataloging search actions into a drop-down menu To test: 1) Go to Cataloging and do a search in the catalog and reservoir (cataloguing/addbooks.pl) 2) Confirm that for the results found in catalog, the options (MARC and Card preview, Edit biblio, Add/edit items) are there and behave as expected. 3) Confirm that for the results found in reservoir, the options (MARC and Card preview, Add biblio) are there and behave as expected. 4) Set user permissions so that the user cannot edit the catalog or items. (editcatalogue -> edit_catalogue and edit_items) 5) Confirm that you no longer see the options to edit or add items/biblio in either table. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Expected result following the test plan. Hi Aleisha, the datatables parts of your patch don't seem to show on the page - can you please check and remove if not needed? Please note - the page also has it's own paging for a lot of results, similar to the authorities. Created attachment 48566 [details] [review] Bug 15952: Moving cataloging search actions into a drop-down menu Edit: Have removed the datatables stuff - wasn't necessary. Also fixed a merge conflict To test: 1) Go to Cataloging and do a search in the catalog and reservoir (cataloguing/addbooks.pl) 2) Confirm that for the results found in catalog, the options (MARC and Card preview, Edit biblio, Add/edit items) are there and behave as expected. 3) Confirm that for the results found in reservoir, the options (MARC and Card preview, Add biblio) are there and behave as expected. 4) Set user permissions so that the user cannot edit the catalog or items. (editcatalogue -> edit_catalogue and edit_items) 5) Confirm that you no longer see the options to edit or add items/biblio in either table. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Expected result following the test plan. Created attachment 48567 [details] [review] Bug 15952: Moving cataloging search actions into a drop-down menu Edit: Have removed the datatables stuff - wasn't necessary. Also fixed a merge conflict To test: 1) Go to Cataloging and do a search in the catalog and reservoir (cataloguing/addbooks.pl) 2) Confirm that for the results found in catalog, the options (MARC and Card preview, Edit biblio, Add/edit items) are there and behave as expected. 3) Confirm that for the results found in reservoir, the options (MARC and Card preview, Add biblio) are there and behave as expected. 4) Set user permissions so that the user cannot edit the catalog or items. (editcatalogue -> edit_catalogue and edit_items) 5) Confirm that you no longer see the options to edit or add items/biblio in either table. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Expected result following the test plan. Created attachment 49058 [details] [review] [SIGNED-OFF] Bug 15952: Moving cataloging search actions into a drop-down menu Edit: Have removed the datatables stuff - wasn't necessary. Also fixed a merge conflict To test: 1) Go to Cataloging and do a search in the catalog and reservoir (cataloguing/addbooks.pl) 2) Confirm that for the results found in catalog, the options (MARC and Card preview, Edit biblio, Add/edit items) are there and behave as expected. 3) Confirm that for the results found in reservoir, the options (MARC and Card preview, Add biblio) are there and behave as expected. 4) Set user permissions so that the user cannot edit the catalog or items. (editcatalogue -> edit_catalogue and edit_items) 5) Confirm that you no longer see the options to edit or add items/biblio in either table. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Expected result following the test plan. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Regression: this patch reintroduced lines deleted by bug 15927 Created attachment 49153 [details] [review] Bug 15952: Moving cataloging search actions into a drop-down menu Edit: Have removed the datatables stuff - wasn't necessary. Also fixed a merge conflict Edit: Comment 7 To test: 1) Go to Cataloging and do a search in the catalog and reservoir (cataloguing/addbooks.pl) 2) Confirm that for the results found in catalog, the options (MARC and Card preview, Edit biblio, Add/edit items) are there and behave as expected. 3) Confirm that for the results found in reservoir, the options (MARC and Card preview, Add biblio) are there and behave as expected. 4) Set user permissions so that the user cannot edit the catalog or items. (editcatalogue -> edit_catalogue and edit_items) 5) Confirm that you no longer see the options to edit or add items/biblio in either table. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Expected result following the test plan. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 49213 [details] [review] Bug 15952: Moving cataloging search actions into a drop-down menu Edit: Have removed the datatables stuff - wasn't necessary. Also fixed a merge conflict Edit: Comment 7 To test: 1) Go to Cataloging and do a search in the catalog and reservoir (cataloguing/addbooks.pl) 2) Confirm that for the results found in catalog, the options (MARC and Card preview, Edit biblio, Add/edit items) are there and behave as expected. 3) Confirm that for the results found in reservoir, the options (MARC and Card preview, Add biblio) are there and behave as expected. 4) Set user permissions so that the user cannot edit the catalog or items. (editcatalogue -> edit_catalogue and edit_items) 5) Confirm that you no longer see the options to edit or add items/biblio in either table. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Expected result following the test plan. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 49214 [details] [review] Bug 15952: Add missing <tr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - should be in the May 2016 release. Thanks! |