Summary: | Tuning function 'New child record' for Unimarc | ||
---|---|---|---|
Product: | Koha | Reporter: | Zeno Tajoli <ztajoli> |
Component: | Cataloging | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | brendan, f.demians, jonathan.druart, julian.maurice, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 6831 | ||
Bug Blocks: | |||
Attachments: |
New child record patch Unimarc
Patch for Unimarc format Followup of the patch Tuning function 'New child record' for Unimarc 205$a -> 461$e Bug 15955: Tuning function 'New child record' for Unimarc 205$a -> 461$e |
Description
Zeno Tajoli
2016-03-02 12:03:09 UTC
This bug is only for Unimarc. When you create a son record with the funcion 'New child record' and EasyAnalitics is off, in Unimarc we tring to insert the value of ediction field (205$a) in subfield $a of 461. This is wrong. Inf fact in 461 is not possible to insert ediction value. This is possible only in MARC21, not in UNIMARC standard Created attachment 48543 [details] [review] New child record patch Unimarc To Test: 1)Check to have EasyAnalyticalRecords on 'off' 2)Check to use UNIMARC 3)Create a record with data in 200$a (title), 205$a (ediction), 700 (author) 215$a(Place), 215$d(date) 4)From those record create a child using 'New'->'New child record' 5)See the values in 461 tag: You can see that in 461$a there is the value of 205$a from father This is wrong, you need to have the value of 700 $a and $b from father record. 6)Appy the patch 7)Redo 4-5 8)Now 461 is good I confirm that Unimarc host 205 field shouldn't be copied into 461$a. But It shouldn't either be suppressed (as with your patch). Shouldn't it be copied into 461$e? In fact I read the standard too quickly. I don't see the subfield $e in 461 Created attachment 48692 [details] [review] Patch for Unimarc format Created attachment 48693 [details] [review] Followup of the patch Hi Frédéric , I have written a follow-up of the patch. Now data from 205$a (of father) will go into 461$e (of child). Created attachment 48700 [details] [review] Tuning function 'New child record' for Unimarc 205$a -> 461$e Now the sYstem tries to insert value of 205$a into 461$a when a child is created from the father record. In UNIMARC 46x tags there is not present a subfield for ediction value (205$a in UNIMARC). To Test: 1) Check to have EasyAnalyticalRecords on 'off' 2) Check to use UNIMARC 3) Create a record with data in 200$a (title), 205$a (ediction), 700 (author) 215$a(Place), 215$d(date) 4) From those record create a child using 'New'->'New child record' 5) See the values in 461 tag: You can see that in 461$a there is the value of 205$a from father This is wrong, you need to have the value of 700 $a and $b from father record, and 205$a in 461$e. 6) Appy the patch 7) Redo 4-5 8) Now 461 is good Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Created attachment 48997 [details] [review] Bug 15955: Tuning function 'New child record' for Unimarc 205$a -> 461$e Now the sYstem tries to insert value of 205$a into 461$a when a child is created from the father record. In UNIMARC 46x tags there is not present a subfield for ediction value (205$a in UNIMARC). To Test: 1) Check to have EasyAnalyticalRecords on 'off' 2) Check to use UNIMARC 3) Create a record with data in 200$a (title), 205$a (ediction), 700 (author) 215$a(Place), 215$d(date) 4) From those record create a child using 'New'->'New child record' 5) See the values in 461 tag: You can see that in 461$a there is the value of 205$a from father This is wrong, you need to have the value of 700 $a and $b from father record, and 205$a in 461$e. 6) Appy the patch 7) Redo 4-5 8) Now 461 is good Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I have not checked the doc but trusting author and signoffer. Pushed to MAster - Should be in the May 2016 release! Thanks! Patch pushed to 3.22.x, will be in 3.22.5 This patch has been pushed to 3.20.x, will be in 3.20.10. |