Description
Marcel de Rooy
2016-03-02 12:38:15 UTC
Created attachment 48544 [details] [review] Bug 15956: Rearranging some SIP unit tests The original SIP_ILS.t is split up into SIP/Patron.t and SIP/Transaction.t. The assumption on a hardcoded existing and non-existing card number is replaced by adding and deleting a card number (:patron) with TestBuilder. Test plan: Run SIP/Patron.t Run SIP/Transaction.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 48545 [details] [review] Bug 15956: Remove warn from handle_patron_status Removes a warn and some commented warns. Test plan: Nothing to do here. Will be covered later by additional unit test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 48546 [details] [review] Bug 15956: Move SIPILS.t to SIP/ILS.t Move the file. Some trivial (cosmetic) edits: whitespace, comments. Test plan: Run SIP/ILS.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 48547 [details] [review] Bug 15956: New unit test SIP/Message.t This patch adds a unit test for testing all handlers in MsgType.pm. For a start, we test the handler for Patron Status requests. A next patch will add tests for Patron Info requests. And hopefully the other handlers will follow.. Note: The tests have been written for SIP protocol version 2. Test plan: Run t/db_dependent/SIP/Message.t If bug 13871 has not yet been pushed, test 12 (subtest 1) will fail. That is no problem. After that push, all tests should no longer fail. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 48656 [details] [review] Bug 15956: New unit test SIP/Message.t This patch adds a unit test for the handlers of Patron Status and Patron Info requests. It can be extended with test for the other handlers later (hopefully). Note: The tests have been written for SIP protocol version 2. Test plan: Run t/db_dependent/SIP/Message.t. Note: If bug 13871 has not yet been pushed, test 12 (subtest 1) should fail with something like 'Code AF not found'. Same for test 15 of subtest 2. That is no problem; after that push, all tests should pass. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 48663 [details] [review] Bug 15956: Rearranging some SIP unit tests The original SIP_ILS.t is split up into SIP/Patron.t and SIP/Transaction.t. The assumption on a hardcoded existing and non-existing card number is replaced by adding and deleting a card number (:patron) with TestBuilder. Test plan: Run SIP/Patron.t Run SIP/Transaction.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 48664 [details] [review] Bug 15956: Remove warn from handle_patron_status Removes a warn and some commented warns. Test plan: Nothing to do here. Will be covered later by additional unit test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 48665 [details] [review] Bug 15956: Move SIPILS.t to SIP/ILS.t Move the file. Some trivial (cosmetic) edits: whitespace, comments. Test plan: Run SIP/ILS.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 48666 [details] [review] Bug 15956: New unit test SIP/Message.t This patch adds a unit test for the handlers of Patron Status and Patron Info requests. It can be extended with test for the other handlers later (hopefully). Note: The tests have been written for SIP protocol version 2. Test plan: Run t/db_dependent/SIP/Message.t. Note: If bug 13871 has not yet been pushed, test 12 (subtest 1) should fail with something like 'Code AF not found'. Same for test 15 of subtest 2. That is no problem; after that push, all tests should pass. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> I have rebased this on top of bug 13871. So please apply that first if not yet pushed. The commit message should be read in that light. Created attachment 50239 [details] [review] [SIGNED-OFF] Bug 15956: Rearranging some SIP unit tests The original SIP_ILS.t is split up into SIP/Patron.t and SIP/Transaction.t. The assumption on a hardcoded existing and non-existing card number is replaced by adding and deleting a card number (:patron) with TestBuilder. Test plan: Run SIP/Patron.t Run SIP/Transaction.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 50240 [details] [review] [SIGNED-OFF] Bug 15956: Remove warn from handle_patron_status Removes a warn and some commented warns. Test plan: Nothing to do here. Will be covered later by additional unit test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 50241 [details] [review] [SIGNED-OFF] Bug 15956: Move SIPILS.t to SIP/ILS.t Move the file. Some trivial (cosmetic) edits: whitespace, comments. Test plan: Run SIP/ILS.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 50242 [details] [review] [SIGNED-OFF] Bug 15956: New unit test SIP/Message.t This patch adds a unit test for the handlers of Patron Status and Patron Info requests. It can be extended with test for the other handlers later (hopefully). Note: The tests have been written for SIP protocol version 2. Test plan: Run t/db_dependent/SIP/Message.t. Note: If bug 13871 has not yet been pushed, test 12 (subtest 1) should fail with something like 'Code AF not found'. Same for test 15 of subtest 2. That is no problem; after that push, all tests should pass. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All tests pass t/db_dependent/SIP/ILS.t .......... ok t/db_dependent/SIP/Message.t ...... ok t/db_dependent/SIP/Patron.t ....... ok t/db_dependent/SIP/Transaction.t .. ok All tests successful. No errors (In reply to Bernardo Gonzalez Kriegel from comment #14) > Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Thx Bernardo! Created attachment 50765 [details] [review] [PASSED QA] Bug 15956: Rearranging some SIP unit tests The original SIP_ILS.t is split up into SIP/Patron.t and SIP/Transaction.t. The assumption on a hardcoded existing and non-existing card number is replaced by adding and deleting a card number (:patron) with TestBuilder. Test plan: Run SIP/Patron.t Run SIP/Transaction.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 50766 [details] [review] [PASSED QA] Bug 15956: Remove warn from handle_patron_status Removes a warn and some commented warns. Test plan: Nothing to do here. Will be covered later by additional unit test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 50767 [details] [review] [PASSED QA] Bug 15956: Move SIPILS.t to SIP/ILS.t Move the file. Some trivial (cosmetic) edits: whitespace, comments. Test plan: Run SIP/ILS.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 50768 [details] [review] [PASSED QA] Bug 15956: New unit test SIP/Message.t This patch adds a unit test for the handlers of Patron Status and Patron Info requests. It can be extended with test for the other handlers later (hopefully). Note: The tests have been written for SIP protocol version 2. Test plan: Run t/db_dependent/SIP/Message.t. Note: If bug 13871 has not yet been pushed, test 12 (subtest 1) should fail with something like 'Code AF not found'. Same for test 15 of subtest 2. That is no problem; after that push, all tests should pass. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All tests pass t/db_dependent/SIP/ILS.t .......... ok t/db_dependent/SIP/Message.t ...... ok t/db_dependent/SIP/Patron.t ....... ok t/db_dependent/SIP/Transaction.t .. ok All tests successful. No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Katrin Fischer from comment #19) > Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thanks, Katrin ! Pushed to master for the May 2016 release. Asante Marcel! |