| Summary: | merge_authorities migration script is broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | brendan, josef.moravec, julian.maurice, remi.mayrand-provencher |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15381 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 16010: follow-up of 15381 - FIX merge_authorities migration script
Bug 16010: follow-up of 15381 - FIX merge_authorities migration script [PASSED QA] Bug 16010: follow-up of 15381 - FIX merge_authorities migration script |
||
Created attachment 48834 [details] [review] Bug 16010: follow-up of 15381 - FIX merge_authorities migration script Caused by commit 7e70202d34d75f988fbaea9b911347417c203aac Bug 15381: Remove GetAuthType and GetAuthTypeCode If you execute perl misc/migration_tools/merge_authority.pl -f 1 -t 2 you will get: Can't locate object method "authtypecode" via package "1" (perhaps you forgot to load "1"?) at misc/migration_tools/merge_authority.pl line 58. GetAuthority does not return a Koha::Authority but a MARC::Record: there is no authtype code method! Test plan: perl misc/migration_tools/merge_authority.pl -f X -t Y Should not return any error. Note that if the authid X or Y does not exist, the script will die. *** Bug 16006 has been marked as a duplicate of this bug. *** Created attachment 48922 [details] [review] Bug 16010: follow-up of 15381 - FIX merge_authorities migration script Caused by commit 7e70202d34d75f988fbaea9b911347417c203aac Bug 15381: Remove GetAuthType and GetAuthTypeCode If you execute perl misc/migration_tools/merge_authority.pl -f 1 -t 2 you will get: Can't locate object method "authtypecode" via package "1" (perhaps you forgot to load "1"?) at misc/migration_tools/merge_authority.pl line 58. GetAuthority does not return a Koha::Authority but a MARC::Record: there is no authtype code method! Test plan: perl misc/migration_tools/merge_authority.pl -f X -t Y Should not return any error. Note that if the authid X or Y does not exist, the script will die. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Interesting! I didn't know about this script yet, something similar for bilbiographic records would be great. Created attachment 49333 [details] [review] [PASSED QA] Bug 16010: follow-up of 15381 - FIX merge_authorities migration script Caused by commit 7e70202d34d75f988fbaea9b911347417c203aac Bug 15381: Remove GetAuthType and GetAuthTypeCode If you execute perl misc/migration_tools/merge_authority.pl -f 1 -t 2 you will get: Can't locate object method "authtypecode" via package "1" (perhaps you forgot to load "1"?) at misc/migration_tools/merge_authority.pl line 58. GetAuthority does not return a Koha::Authority but a MARC::Record: there is no authtype code method! Test plan: perl misc/migration_tools/merge_authority.pl -f X -t Y Should not return any error. Note that if the authid X or Y does not exist, the script will die. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 release. Thanks! Does not concern stable versions, status changed to RESOLVED |
Caused by commit 7e70202d34d75f988fbaea9b911347417c203aac Bug 15381: Remove GetAuthType and GetAuthTypeCode If you execute perl misc/migration_tools/merge_authority.pl -f 1 -t 2 you will get: Can't locate object method "authtypecode" via package "1" (perhaps you forgot to load "1"?) at misc/migration_tools/merge_authority.pl line 58.