Bug 16010 - merge_authorities migration script is broken
Summary: merge_authorities migration script is broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
: 16006 (view as bug list)
Depends on: 15381
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-09 08:17 UTC by Jonathan Druart
Modified: 2019-06-27 09:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16010: follow-up of 15381 - FIX merge_authorities migration script (1.72 KB, patch)
2016-03-09 08:25 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16010: follow-up of 15381 - FIX merge_authorities migration script (1.86 KB, patch)
2016-03-10 05:57 UTC, Frédéric Demians
Details | Diff | Splinter Review
[PASSED QA] Bug 16010: follow-up of 15381 - FIX merge_authorities migration script (1.93 KB, patch)
2016-03-20 16:11 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-03-09 08:17:20 UTC
Caused by commit 7e70202d34d75f988fbaea9b911347417c203aac
    Bug 15381: Remove GetAuthType and GetAuthTypeCode

If you execute perl misc/migration_tools/merge_authority.pl -f 1 -t 2
you will get:
Can't locate object method "authtypecode" via package "1" (perhaps you forgot to load "1"?) at misc/migration_tools/merge_authority.pl 
line 58.
Comment 1 Jonathan Druart 2016-03-09 08:25:07 UTC Comment hidden (obsolete)
Comment 2 Rémi Mayrand-Provencher 2016-03-09 16:59:24 UTC
*** Bug 16006 has been marked as a duplicate of this bug. ***
Comment 3 Frédéric Demians 2016-03-10 05:57:19 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2016-03-20 16:08:52 UTC
Interesting! I didn't know about this script yet, something similar for bilbiographic records would be great.
Comment 5 Katrin Fischer 2016-03-20 16:11:51 UTC
Created attachment 49333 [details] [review]
[PASSED QA] Bug 16010: follow-up of 15381 - FIX merge_authorities migration script

Caused by commit 7e70202d34d75f988fbaea9b911347417c203aac
    Bug 15381: Remove GetAuthType and GetAuthTypeCode

If you execute perl misc/migration_tools/merge_authority.pl -f 1 -t 2
you will get:
Can't locate object method "authtypecode" via package "1" (perhaps you forgot to load "1"?)
 at misc/migration_tools/merge_authority.pl line 58.

GetAuthority does not return a Koha::Authority but a MARC::Record:
there is no authtype code method!

Test plan:
perl misc/migration_tools/merge_authority.pl -f X -t Y
Should not return any error.
Note that if the authid X or Y does not exist, the script will die.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Brendan Gallagher 2016-03-21 18:29:29 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 7 Julian Maurice 2016-03-23 07:09:23 UTC
Does not concern stable versions, status changed to RESOLVED