| Summary: | Use Font Awesome icon in hold confirmation dialog | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | brendan, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/circ/returns.pl | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 16080 | ||
| Attachments: |
Bug 16043 - Use Font Awesome icon in hold confirmation dialog
Bug 16043 - Use Font Awesome icon in hold confirmation dialog Bug 16043 - Use Font Awesome icon in hold confirmation dialog |
||
|
Description
Owen Leonard
2016-03-10 15:30:58 UTC
Created attachment 48966 [details] [review] Bug 16043 - Use Font Awesome icon in hold confirmation dialog This patch fixes another instance in the checkin template where a Font Awesome icon should be used instead of a background image. To test, apply the patch and locate an item which is on hold for a patron at your logged in library. - Check in the item. - Confirm the hold. - Check in the item again. - You should get a "Hold found (item is already waiting)" message. The "Print and confirm" button in this dialog should have a Font Awesome icon. - Confirm that the print button still works correctly. Created attachment 49191 [details] [review] Bug 16043 - Use Font Awesome icon in hold confirmation dialog This patch fixes another instance in the checkin template where a Font Awesome icon should be used instead of a background image. To test, apply the patch and locate an item which is on hold for a patron at your logged in library. - Check in the item. - Confirm the hold. - Check in the item again. - You should get a "Hold found (item is already waiting)" message. The "Print and confirm" button in this dialog should have a Font Awesome icon. - Confirm that the print button still works correctly. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49210 [details] [review] Bug 16043 - Use Font Awesome icon in hold confirmation dialog This patch fixes another instance in the checkin template where a Font Awesome icon should be used instead of a background image. To test, apply the patch and locate an item which is on hold for a patron at your logged in library. - Check in the item. - Confirm the hold. - Check in the item again. - You should get a "Hold found (item is already waiting)" message. The "Print and confirm" button in this dialog should have a Font Awesome icon. - Confirm that the print button still works correctly. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - should be in the May 2016 release. Thanks! |