There is one stray instance in the returns template of a button in a hold confirmation dialog which should use a Font Awesome icon instead of a background image.
Created attachment 48966 [details] [review] Bug 16043 - Use Font Awesome icon in hold confirmation dialog This patch fixes another instance in the checkin template where a Font Awesome icon should be used instead of a background image. To test, apply the patch and locate an item which is on hold for a patron at your logged in library. - Check in the item. - Confirm the hold. - Check in the item again. - You should get a "Hold found (item is already waiting)" message. The "Print and confirm" button in this dialog should have a Font Awesome icon. - Confirm that the print button still works correctly.
Created attachment 49191 [details] [review] Bug 16043 - Use Font Awesome icon in hold confirmation dialog This patch fixes another instance in the checkin template where a Font Awesome icon should be used instead of a background image. To test, apply the patch and locate an item which is on hold for a patron at your logged in library. - Check in the item. - Confirm the hold. - Check in the item again. - You should get a "Hold found (item is already waiting)" message. The "Print and confirm" button in this dialog should have a Font Awesome icon. - Confirm that the print button still works correctly. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 49210 [details] [review] Bug 16043 - Use Font Awesome icon in hold confirmation dialog This patch fixes another instance in the checkin template where a Font Awesome icon should be used instead of a background image. To test, apply the patch and locate an item which is on hold for a patron at your logged in library. - Check in the item. - Confirm the hold. - Check in the item again. - You should get a "Hold found (item is already waiting)" message. The "Print and confirm" button in this dialog should have a Font Awesome icon. - Confirm that the print button still works correctly. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - should be in the May 2016 release. Thanks!