| Summary: | Use Font Awesome icons in OAI sets administration | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | brendan |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/admin/oai_sets.pl | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15991, 16014 | ||
| Bug Blocks: | 16080 | ||
| Attachments: |
Bug 16045 - Use Font Awesome icons in OAI sets administration
[SIGNED-OFF] Bug 16045 - Use Font Awesome icons in OAI sets administration Bug 16045 - Use Font Awesome icons in OAI sets administration |
||
|
Description
Owen Leonard
2016-03-10 16:02:44 UTC
Created attachment 48969 [details] [review] Bug 16045 - Use Font Awesome icons in OAI sets administration There are links on the OAI sets administration page which can use Font Awesome icons instead of being styled with background images. This patch makes that change. Another minor change: Added the "fa-fw" class to items in the "Actions" menu which didn't have it. This helps the items line up correctly: http://fortawesome.github.io/Font-Awesome/examples/#fixed-width To test, apply the patches for Bugs 16014 and 15991 if necessary. Apply this patch and: - Go to Administration -> OAI sets configuration. - Click the "New set" button and verify that the "Add description" link uses a Font Awesome icon. - Confirm that the "Add description" link works correctly. - After adding a description, verify that the "Remove" link looks correct and works correctly. - From the list of OAI sets choose "Define mappings" from the "Actions" menu. - Confirm that the "Delete" button is styled correctly and works correctly. Created attachment 48977 [details] [review] [SIGNED-OFF] Bug 16045 - Use Font Awesome icons in OAI sets administration There are links on the OAI sets administration page which can use Font Awesome icons instead of being styled with background images. This patch makes that change. Another minor change: Added the "fa-fw" class to items in the "Actions" menu which didn't have it. This helps the items line up correctly: http://fortawesome.github.io/Font-Awesome/examples/#fixed-width To test, apply the patches for Bugs 16014 and 15991 if necessary. Apply this patch and: - Go to Administration -> OAI sets configuration. - Click the "New set" button and verify that the "Add description" link uses a Font Awesome icon. - Confirm that the "Add description" link works correctly. - After adding a description, verify that the "Remove" link looks correct and works correctly. - From the list of OAI sets choose "Define mappings" from the "Actions" menu. - Confirm that the "Delete" button is styled correctly and works correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Created attachment 48999 [details] [review] Bug 16045 - Use Font Awesome icons in OAI sets administration There are links on the OAI sets administration page which can use Font Awesome icons instead of being styled with background images. This patch makes that change. Another minor change: Added the "fa-fw" class to items in the "Actions" menu which didn't have it. This helps the items line up correctly: http://fortawesome.github.io/Font-Awesome/examples/#fixed-width To test, apply the patches for Bugs 16014 and 15991 if necessary. Apply this patch and: - Go to Administration -> OAI sets configuration. - Click the "New set" button and verify that the "Add description" link uses a Font Awesome icon. - Confirm that the "Add description" link works correctly. - After adding a description, verify that the "Remove" link looks correct and works correctly. - From the list of OAI sets choose "Define mappings" from the "Actions" menu. - Confirm that the "Delete" button is styled correctly and works correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! |