Bug 16045 - Use Font Awesome icons in OAI sets administration
Summary: Use Font Awesome icons in OAI sets administration
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/oai_sets.pl
Keywords:
Depends on: 15991 16014
Blocks: 16080
  Show dependency treegraph
 
Reported: 2016-03-10 16:02 UTC by Owen Leonard
Modified: 2017-06-14 22:07 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16045 - Use Font Awesome icons in OAI sets administration (5.78 KB, patch)
2016-03-10 16:18 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16045 - Use Font Awesome icons in OAI sets administration (5.80 KB, patch)
2016-03-10 21:23 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16045 - Use Font Awesome icons in OAI sets administration (5.86 KB, patch)
2016-03-11 10:22 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-10 16:02:44 UTC
There are some links on the OAI administration pages which are styled with background images. These can be updated to use Font Awesome icons.
Comment 1 Owen Leonard 2016-03-10 16:18:34 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-03-10 21:23:02 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-11 10:22:03 UTC
Created attachment 48999 [details] [review]
Bug 16045 - Use Font Awesome icons in OAI sets administration

There are links on the OAI sets administration page which can use Font
Awesome icons instead of being styled with background images. This patch
makes that change.

Another minor change: Added the "fa-fw" class to items in the "Actions"
menu which didn't have it. This helps the items line up correctly:
http://fortawesome.github.io/Font-Awesome/examples/#fixed-width

To test, apply the patches for Bugs 16014 and 15991 if necessary. Apply
this patch and:

- Go to Administration ->  OAI sets configuration.
- Click the "New set" button and verify that the "Add description" link
  uses a Font Awesome icon.
- Confirm that the "Add description" link works correctly.
- After adding a description, verify that the "Remove" link looks
  correct and works correctly.
- From the list of OAI sets choose "Define mappings" from the "Actions"
  menu.
- Confirm that the "Delete" button is styled correctly and works
  correctly.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-12 23:45:27 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!