| Summary: | Plack - variable scope error in paycollect.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | brendan, f.demians, josef.moravec, julian.maurice |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 7172 | ||
| Attachments: |
Bug 16054: Fix variable scope error in paycollect.pl
[SIGNED-OFF] Bug 16054: Fix variable scope error in paycollect.pl Bug 16054: Fix variable scope error in paycollect.pl |
||
|
Description
Jonathan Druart
2016-03-11 12:45:55 UTC
Created attachment 49006 [details] [review] Bug 16054: Fix variable scope error in paycollect.pl $borrower, $borrowernumber and $template and not visible in the subroutine. Using $b_ref and passing $template fixes the issue. Test plan: Under plack, use the pay selected button. On the paycollect page, you should see the image of the patron It certainly fixes some other bugs. Created attachment 49080 [details] [review] [SIGNED-OFF] Bug 16054: Fix variable scope error in paycollect.pl $borrower, $borrowernumber and $template and not visible in the subroutine. Using $b_ref and passing $template fixes the issue. Test plan: Under plack, use the pay selected button. On the paycollect page, you should see the image of the patron It certainly fixes some other bugs. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Created attachment 49148 [details] [review] Bug 16054: Fix variable scope error in paycollect.pl $borrower, $borrowernumber and $template and not visible in the subroutine. Using $b_ref and passing $template fixes the issue. Test plan: Under plack, use the pay selected button. On the paycollect page, you should see the image of the patron It certainly fixes some other bugs. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.5 Pushed to 3.20.x, will be in 3.20.10 |