Bug 16054

Summary: Plack - variable scope error in paycollect.pl
Product: Koha Reporter: Jonathan Druart <jonathan.druart+koha>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart+koha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: brendan, frederic, josef.moravec, julian.maurice
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 7172    
Attachments: Bug 16054: Fix variable scope error in paycollect.pl
[SIGNED-OFF] Bug 16054: Fix variable scope error in paycollect.pl
Bug 16054: Fix variable scope error in paycollect.pl

Description Jonathan Druart 2016-03-11 12:45:55 UTC

    
Comment 1 Jonathan Druart 2016-03-11 12:49:28 UTC Comment hidden (obsolete)
Comment 2 Srdjan Jankovic 2016-03-14 00:15:24 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2016-03-14 19:09:59 UTC
Created attachment 49148 [details] [review]
Bug 16054: Fix variable scope error in paycollect.pl

$borrower, $borrowernumber and $template and not visible in the
subroutine.
Using $b_ref and passing $template fixes the issue.

Test plan:
Under plack, use the pay selected button.
On the paycollect page, you should see the image of the patron

It certainly fixes some other bugs.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Brendan Gallagher 2016-03-15 07:13:55 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-03-17 07:54:37 UTC
Patch pushed to 3.22.x, will be in 3.22.5
Comment 6 Frédéric Demians 2016-03-23 12:51:19 UTC
Pushed to 3.20.x, will be in 3.20.10