Created attachment 49006 [details] [review] Bug 16054: Fix variable scope error in paycollect.pl $borrower, $borrowernumber and $template and not visible in the subroutine. Using $b_ref and passing $template fixes the issue. Test plan: Under plack, use the pay selected button. On the paycollect page, you should see the image of the patron It certainly fixes some other bugs.
Created attachment 49080 [details] [review] [SIGNED-OFF] Bug 16054: Fix variable scope error in paycollect.pl $borrower, $borrowernumber and $template and not visible in the subroutine. Using $b_ref and passing $template fixes the issue. Test plan: Under plack, use the pay selected button. On the paycollect page, you should see the image of the patron It certainly fixes some other bugs. Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Created attachment 49148 [details] [review] Bug 16054: Fix variable scope error in paycollect.pl $borrower, $borrowernumber and $template and not visible in the subroutine. Using $b_ref and passing $template fixes the issue. Test plan: Under plack, use the pay selected button. On the paycollect page, you should see the image of the patron It certainly fixes some other bugs. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to Master - Should be in the May 2016 release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.5
Pushed to 3.20.x, will be in 3.20.10