| Summary: | Error messages for library transfers show with bullet points | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
| Component: | Circulation | Assignee: | Aleisha Amohia <aleisha> |
| Status: | Pushed to stable --- | QA Contact: | Laura Escamilla <Laura.escamilla> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, gmcharlt, jonathan.druart, josef.moravec, kyle, Laura.escamilla, oleonard, veron |
| Version: | Main | Keywords: | Academy, Sandbox |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | Sponsored | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
When transferring items (Circulation > Transfers > Transfer), any error messages are shown as a bulleted list in one alert box.
If there is only one error, it looks a bit odd having a bulleted list with only one item.
With this enhancement, each error message is now shown in its own alert box.
|
Version(s) released in: |
26.05.00,25.11.02
|
| Circulation function: | |||
| Attachments: |
Bug 16131: Messages for branch transfers show with bullet points
Bug 16131: Messages for branch transfers show with bullet points Bug 16131: Show branch transfer error messages in separate alert boxes Bug 16131: Show branch transfer error messages in separate alert boxes Bug 16131: Show branch transfer error messages in separate alert boxes |
||
|
Description
Aleisha Amohia
2016-03-23 03:47:14 UTC
Created attachment 49422 [details] [review] Bug 16131: Messages for branch transfers show with bullet points This patches removes the list code from the messages To test: 1) Attempt to transfer an item to its home library. Confirm no bullet point in message 2) Check out an item to a user. Attempt to transfer the same item. Confirm no bullet point in message 3) Set syspref BranchTransferLimitsType to Enforce for item types. Go to Admin -> Library transfer limits and select a library (Library B) other than your home library (Library A). Uncheck all options. Go back to branch transfers and attempt to transfer an item from Library A to Library B. Confirm no bullet point in message. Sponsored-by: Catalyst IT Created attachment 49427 [details] [review] Bug 16131: Messages for branch transfers show with bullet points This patches removes the list code from the messages To test: 1) Attempt to transfer an item to its home library. Confirm no bullet point in message 2) Check out an item to a user. Attempt to transfer the same item. Confirm no bullet point in message 3) Set syspref BranchTransferLimitsType to Enforce for item types. Go to Admin -> Library transfer limits and select a library (Library B) other than your home library (Library A). Uncheck all options. Go back to branch transfers and attempt to transfer an item from Library A to Library B. Confirm no bullet point in message. Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> (In reply to Aleisha Amohia from comment #0) > The branch transfer messages are styled as a list and show with bullet > points. And, what the problem with that? That could be achieve with some css (something like list-style: none;) I think the bullet points are there because mulitple errors can apply at the same time. If we just remove the <ul><li> without replacing it with something else, we have the issue that the text of different errors will flow into each other. I tested like this: * Check out Centerville item to someone in Centerville * Transfer that item to Centerville Errors shown are: * Item is already at destination library. * Item was on loan to koha (42) and has been returned. So I think the patch would need more work, but we probably also need to think about how we wan this to look like. Multiple 'blue' dialog boxes for mulitple errors? (In reply to Katrin Fischer from comment #4) > > Multiple 'blue' dialog boxes for mulitple errors? That sounds like a good option to me. Created attachment 190642 [details] [review] Bug 16131: Show branch transfer error messages in separate alert boxes Currently error messages show in one alert box as bullet points. When there is only one error shown, this looks a bit strange to have a list with one item. This enhancement displays each error message as its own alert box. To test: 1. Check out a Centerville item to someone in Centerville. For example, check out 39999000004175 to yourself. 2. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Centerville. 3. Confirm two error messages are shown, with one blue box for each. 4. Go to Koha administration -> System preferences. Set UseBranchTransferLimits to Enforce and BranchTransferLimitsType to collection code. 5. Go to Koha administration -> Library transfer limits. Go to the REF tab and uncheck the Allow transfer? box for FFL - Fairfield, then hit Save 6. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Fairfield. 7. Confirm the error message shows in a blue box with no bullet point. 8. Type something random in the item barcode box and click Transfer. 9. Confirm the error message shows in a blue box with no bullet point. Sponsored-by: Catalyst IT Created attachment 190645 [details] [review] Bug 16131: Show branch transfer error messages in separate alert boxes Currently error messages show in one alert box as bullet points. When there is only one error shown, this looks a bit strange to have a list with one item. This enhancement displays each error message as its own alert box. To test: 1. Check out a Centerville item to someone in Centerville. For example, check out 39999000004175 to yourself. 2. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Centerville. 3. Confirm two error messages are shown, with one blue box for each. 4. Go to Koha administration -> System preferences. Set UseBranchTransferLimits to Enforce and BranchTransferLimitsType to collection code. 5. Go to Koha administration -> Library transfer limits. Go to the REF tab and uncheck the Allow transfer? box for FFL - Fairfield, then hit Save 6. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Fairfield. 7. Confirm the error message shows in a blue box with no bullet point. 8. Type something random in the item barcode box and click Transfer. 9. Confirm the error message shows in a blue box with no bullet point. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 190684 [details] [review] Bug 16131: Show branch transfer error messages in separate alert boxes Currently error messages show in one alert box as bullet points. When there is only one error shown, this looks a bit strange to have a list with one item. This enhancement displays each error message as its own alert box. To test: 1. Check out a Centerville item to someone in Centerville. For example, check out 39999000004175 to yourself. 2. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Centerville. 3. Confirm two error messages are shown, with one blue box for each. 4. Go to Koha administration -> System preferences. Set UseBranchTransferLimits to Enforce and BranchTransferLimitsType to collection code. 5. Go to Koha administration -> Library transfer limits. Go to the REF tab and uncheck the Allow transfer? box for FFL - Fairfield, then hit Save 6. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Fairfield. 7. Confirm the error message shows in a blue box with no bullet point. 8. Type something random in the item barcode box and click Transfer. 9. Confirm the error message shows in a blue box with no bullet point. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Nice work everyone! Pushed to main for 26.05 Something I noted when attempting to write a release note. The error messages are shown in a blue alert box (CSS style = alert alert-info), which is more for information than an error. Should this be a yellow alert box? I'm sure I've seen this somewhere about what type to use for different types of messages, but can't find it now... All pushed to 25.11.x Thanks all! |