Bug 16131 - Error messages for library transfers show with bullet points
Summary: Error messages for library transfers show with bullet points
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Aleisha Amohia
QA Contact: Laura Escamilla
URL:
Keywords: Academy, Sandbox
Depends on:
Blocks:
 
Reported: 2016-03-23 03:47 UTC by Aleisha Amohia
Modified: 2026-02-03 15:01 UTC (History)
8 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: Sponsored
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
When transferring items (Circulation > Transfers > Transfer), any error messages are shown as a bulleted list in one alert box. If there is only one error, it looks a bit odd having a bulleted list with only one item. With this enhancement, each error message is now shown in its own alert box.
Version(s) released in:
26.05.00,25.11.02
Circulation function:


Attachments
Bug 16131: Messages for branch transfers show with bullet points (3.88 KB, patch)
2016-03-23 04:01 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16131: Messages for branch transfers show with bullet points (4.01 KB, patch)
2016-03-23 08:19 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16131: Show branch transfer error messages in separate alert boxes (6.39 KB, patch)
2025-12-19 02:51 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16131: Show branch transfer error messages in separate alert boxes (6.46 KB, patch)
2025-12-19 12:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16131: Show branch transfer error messages in separate alert boxes (6.53 KB, patch)
2025-12-22 16:45 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-23 03:47:14 UTC
The branch transfer messages are styled as a list and show with bullet points.
Comment 1 Aleisha Amohia 2016-03-23 04:01:26 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-03-23 08:19:30 UTC
Created attachment 49427 [details] [review]
Bug 16131: Messages for branch transfers show with bullet points

This patches removes the list code from the messages

To test:
1) Attempt to transfer an item to its home library. Confirm no bullet point in message
2) Check out an item to a user. Attempt to transfer the same item. Confirm no bullet point in message
3) Set syspref BranchTransferLimitsType to Enforce for item types. Go to Admin -> Library transfer limits and select a library (Library B) other than your home library (Library A). Uncheck all options. Go back to branch transfers and attempt to transfer an item from Library A to Library B. Confirm no bullet point in message.

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 3 Jonathan Druart 2016-03-23 22:16:50 UTC
(In reply to Aleisha Amohia from comment #0)
> The branch transfer messages are styled as a list and show with bullet
> points.

And, what the problem with that?
That could be achieve with some css (something like list-style: none;)
Comment 4 Katrin Fischer 2023-09-09 18:55:26 UTC
I think the bullet points are there because mulitple errors can apply at the same time. If we just remove the <ul><li> without replacing it with something else, we have the issue that the text of different errors will flow into each other.

I tested like this:
* Check out Centerville item to someone in Centerville
* Transfer that item to Centerville

Errors shown are:

* Item is already at destination library.
* Item was on loan to koha (42) and has been returned.

So I think the patch would need more work, but we probably also need to think about how we wan this to look like.

Multiple 'blue' dialog boxes for mulitple errors?
Comment 5 Aleisha Amohia 2023-09-10 22:14:10 UTC
(In reply to Katrin Fischer from comment #4)
> 
> Multiple 'blue' dialog boxes for mulitple errors?

That sounds like a good option to me.
Comment 6 Aleisha Amohia 2025-12-19 02:51:32 UTC
Created attachment 190642 [details] [review]
Bug 16131: Show branch transfer error messages in separate alert boxes

Currently error messages show in one alert box as bullet points. When there is only one error shown, this looks a bit strange to have a list with one item. This enhancement displays each error message as its own alert box.

To test:

1. Check out a Centerville item to someone in Centerville. For example, check out 39999000004175 to yourself.
2. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Centerville.
3. Confirm two error messages are shown, with one blue box for each.

4. Go to Koha administration -> System preferences. Set UseBranchTransferLimits to Enforce and BranchTransferLimitsType to collection code.
5. Go to Koha administration -> Library transfer limits. Go to the REF tab and uncheck the Allow transfer? box for FFL - Fairfield, then hit Save
6. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Fairfield.
7. Confirm the error message shows in a blue box with no bullet point.

8. Type something random in the item barcode box and click Transfer.
9. Confirm the error message shows in a blue box with no bullet point.

Sponsored-by: Catalyst IT
Comment 7 Owen Leonard 2025-12-19 12:47:13 UTC
Created attachment 190645 [details] [review]
Bug 16131: Show branch transfer error messages in separate alert boxes

Currently error messages show in one alert box as bullet points. When
there is only one error shown, this looks a bit strange to have a list
with one item. This enhancement displays each error message as its own
alert box.

To test:

1. Check out a Centerville item to someone in Centerville. For example,
   check out 39999000004175 to yourself.
2. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and
   transfer the item to Centerville.
3. Confirm two error messages are shown, with one blue box for each.

4. Go to Koha administration -> System preferences. Set
   UseBranchTransferLimits to Enforce and BranchTransferLimitsType to
   collection code.
5. Go to Koha administration -> Library transfer limits. Go to the REF
   tab and uncheck the Allow transfer? box for FFL - Fairfield, then hit
   Save
6. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and
   transfer the item to Fairfield.
7. Confirm the error message shows in a blue box with no bullet point.
8. Type something random in the item barcode box and click Transfer.
9. Confirm the error message shows in a blue box with no bullet point.

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 8 Laura Escamilla 2025-12-22 16:45:38 UTC
Created attachment 190684 [details] [review]
Bug 16131: Show branch transfer error messages in separate alert boxes

Currently error messages show in one alert box as bullet points. When
there is only one error shown, this looks a bit strange to have a list
with one item. This enhancement displays each error message as its own
alert box.

To test:

1. Check out a Centerville item to someone in Centerville. For example,
   check out 39999000004175 to yourself.
2. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and
   transfer the item to Centerville.
3. Confirm two error messages are shown, with one blue box for each.

4. Go to Koha administration -> System preferences. Set
   UseBranchTransferLimits to Enforce and BranchTransferLimitsType to
   collection code.
5. Go to Koha administration -> Library transfer limits. Go to the REF
   tab and uncheck the Allow transfer? box for FFL - Fairfield, then hit
   Save
6. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and
   transfer the item to Fairfield.
7. Confirm the error message shows in a blue box with no bullet point.
8. Type something random in the item barcode box and click Transfer.
9. Confirm the error message shows in a blue box with no bullet point.

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 9 Lucas Gass (lukeg) 2025-12-30 14:51:19 UTC
Nice work everyone!

Pushed to main for 26.05
Comment 10 David Nind 2025-12-31 20:47:35 UTC
Something I noted when attempting to write a release note.

The error messages are shown in a blue alert box (CSS style = alert alert-info), which is more for information than an error.

Should this be a yellow alert box? 

I'm sure I've seen this somewhere about what type to use for different types of messages, but can't find it now...
Comment 11 Chloé Zermatten 2026-02-03 15:01:48 UTC
All pushed to 25.11.x Thanks all!