The branch transfer messages are styled as a list and show with bullet points.
Created attachment 49422 [details] [review] Bug 16131: Messages for branch transfers show with bullet points This patches removes the list code from the messages To test: 1) Attempt to transfer an item to its home library. Confirm no bullet point in message 2) Check out an item to a user. Attempt to transfer the same item. Confirm no bullet point in message 3) Set syspref BranchTransferLimitsType to Enforce for item types. Go to Admin -> Library transfer limits and select a library (Library B) other than your home library (Library A). Uncheck all options. Go back to branch transfers and attempt to transfer an item from Library A to Library B. Confirm no bullet point in message. Sponsored-by: Catalyst IT
Created attachment 49427 [details] [review] Bug 16131: Messages for branch transfers show with bullet points This patches removes the list code from the messages To test: 1) Attempt to transfer an item to its home library. Confirm no bullet point in message 2) Check out an item to a user. Attempt to transfer the same item. Confirm no bullet point in message 3) Set syspref BranchTransferLimitsType to Enforce for item types. Go to Admin -> Library transfer limits and select a library (Library B) other than your home library (Library A). Uncheck all options. Go back to branch transfers and attempt to transfer an item from Library A to Library B. Confirm no bullet point in message. Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch>
(In reply to Aleisha Amohia from comment #0) > The branch transfer messages are styled as a list and show with bullet > points. And, what the problem with that? That could be achieve with some css (something like list-style: none;)
I think the bullet points are there because mulitple errors can apply at the same time. If we just remove the <ul><li> without replacing it with something else, we have the issue that the text of different errors will flow into each other. I tested like this: * Check out Centerville item to someone in Centerville * Transfer that item to Centerville Errors shown are: * Item is already at destination library. * Item was on loan to koha (42) and has been returned. So I think the patch would need more work, but we probably also need to think about how we wan this to look like. Multiple 'blue' dialog boxes for mulitple errors?
(In reply to Katrin Fischer from comment #4) > > Multiple 'blue' dialog boxes for mulitple errors? That sounds like a good option to me.