Bug 16131 - Messages for branch transfers show with bullet points
Summary: Messages for branch transfers show with bullet points
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-23 03:47 UTC by Aleisha Amohia
Modified: 2023-09-10 22:14 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16131: Messages for branch transfers show with bullet points (3.88 KB, patch)
2016-03-23 04:01 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16131: Messages for branch transfers show with bullet points (4.01 KB, patch)
2016-03-23 08:19 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-23 03:47:14 UTC
The branch transfer messages are styled as a list and show with bullet points.
Comment 1 Aleisha Amohia 2016-03-23 04:01:26 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-03-23 08:19:30 UTC
Created attachment 49427 [details] [review]
Bug 16131: Messages for branch transfers show with bullet points

This patches removes the list code from the messages

To test:
1) Attempt to transfer an item to its home library. Confirm no bullet point in message
2) Check out an item to a user. Attempt to transfer the same item. Confirm no bullet point in message
3) Set syspref BranchTransferLimitsType to Enforce for item types. Go to Admin -> Library transfer limits and select a library (Library B) other than your home library (Library A). Uncheck all options. Go back to branch transfers and attempt to transfer an item from Library A to Library B. Confirm no bullet point in message.

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 3 Jonathan Druart 2016-03-23 22:16:50 UTC
(In reply to Aleisha Amohia from comment #0)
> The branch transfer messages are styled as a list and show with bullet
> points.

And, what the problem with that?
That could be achieve with some css (something like list-style: none;)
Comment 4 Katrin Fischer 2023-09-09 18:55:26 UTC
I think the bullet points are there because mulitple errors can apply at the same time. If we just remove the <ul><li> without replacing it with something else, we have the issue that the text of different errors will flow into each other.

I tested like this:
* Check out Centerville item to someone in Centerville
* Transfer that item to Centerville

Errors shown are:

* Item is already at destination library.
* Item was on loan to koha (42) and has been returned.

So I think the patch would need more work, but we probably also need to think about how we wan this to look like.

Multiple 'blue' dialog boxes for mulitple errors?
Comment 5 Aleisha Amohia 2023-09-10 22:14:10 UTC
(In reply to Katrin Fischer from comment #4)
> 
> Multiple 'blue' dialog boxes for mulitple errors?

That sounds like a good option to me.