Summary: | Koha::Patron contains 'return undef' and fails critic tests | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, jonathan.druart, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 15656 | ||
Bug Blocks: | |||
Attachments: |
Bug 16136: Koha::Patron contains 'return undef' and fails critic tests
Bug 16136: Koha::Patron contains 'return undef' and fails critic tests |
Description
Tomás Cohen Arazi (tcohen)
2016-03-23 17:57:02 UTC
Created attachment 49456 [details] [review] Bug 16136: Koha::Patron contains 'return undef' and fails critic tests This patch fixes this issue. To test: - Run $ TEST_QA=1 prove t/00-testcritic.t => FAIL: Koha::Patron makes the tests fail. - Apply the patch - Run $ TEST_QA=1 prove t/00-testcritic.t => SUCCESS: tests PASS - Sign off Regards Created attachment 49458 [details] [review] Bug 16136: Koha::Patron contains 'return undef' and fails critic tests This patch fixes this issue. To test: - Run $ TEST_QA=1 prove t/00-testcritic.t => FAIL: Koha::Patron makes the tests fail. - Apply the patch - Run $ TEST_QA=1 prove t/00-testcritic.t => SUCCESS: tests PASS - Sign off Regards Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Skipping QA. Pushed to Master - Should be in the May 2016 release. Thanks! Not needed in stable versions, status changed to RESOLVED |