Bug 16178

Summary: Tests for xt/single_quotes.t are failing
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: brendan, julian.maurice, m.de.rooy, mtompset
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 15206    
Bug Blocks:    
Attachments: Bug 16178: Fix tests for xt/single_quotes.t
Bug 16178: Fix tests for xt/single_quotes.t
Bug 16178: Fix tests for xt/single_quotes.t

Description Jonathan Druart 2016-03-31 08:05:21 UTC

    
Comment 1 Jonathan Druart 2016-03-31 08:07:44 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens (kidclamp) 2016-03-31 19:16:07 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2016-04-01 08:35:51 UTC
Created attachment 49776 [details] [review]
Bug 16178: Fix tests for xt/single_quotes.t

Caused by
  commit 9c5c1bc9f104b125e06b3805ce510024e6ad34ac
    Bug 15206: Make strings translatable

Test plan:
  prove xt/single_quotes.t
should return green

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2016-04-01 08:37:46 UTC
Spotted another one (outside the templates) too:
cataloguing/value_builder/unimarc_leader.pl:        alert(_('leader has an incor

But fixing that one is useless.
Comment 5 Brendan Gallagher 2016-04-01 19:06:30 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 6 Julian Maurice 2016-04-07 08:20:14 UTC
Not needed in stable versions, status changed to RESOLVED