Summary: | Make phone number clickable to call | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Patrons | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle.m.hall, kyle, m.de.rooy, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16182: Make phone number clickable to call
Bug 16182: Make phone number clickable to call Bug 16182: Make phone number clickable to call Bug 16182: Make phone number clickable to call |
Description
Aleisha Amohia
2016-03-31 21:35:17 UTC
Created attachment 49747 [details] [review] Bug 16182: Make phone number clickable to call To test: 1) Go to a patron detail page 2) Confirm that all available phone numbers can be clicked and allow you to call this number from your device a) in the top left circ-menu.inc b) primary/secondary/other/organisation/mobile phone numbers c) alternate address phone number d) alternate contact phone number e) enable the EnhancedMessagingPreferences system preference. check the SMS number under Patron messaging preferences (back on the detail page) is clickable 3) Check to see if there are any phone numbers I have missed. Sponsored-by: Catalyst IT Should the SMS number link use '<a href="sms: ' instead? Failing because there is a typo in moremember.tt on line 225: <a href="te: Created attachment 50045 [details] [review] Bug 16182: Make phone number clickable to call EDIT: fixing typo, changing sms number from tel: to sms: To test: 1) Go to a patron detail page 2) Confirm that all available phone numbers can be clicked and allow you to call this number from your device a) in the top left circ-menu.inc b) primary/secondary/other/organisation/mobile phone numbers c) alternate address phone number d) alternate contact phone number e) enable the EnhancedMessagingPreferences system preference. check the SMS number under Patron messaging preferences (back on the detail page) is clickable 3) Check to see if there are any phone numbers I have missed. Sponsored-by: Catalyst IT Created attachment 50053 [details] [review] Bug 16182: Make phone number clickable to call EDIT: fixing typo, changing sms number from tel: to sms: To test: 1) Go to a patron detail page 2) Confirm that all available phone numbers can be clicked and allow you to call this number from your device a) in the top left circ-menu.inc b) primary/secondary/other/organisation/mobile phone numbers c) alternate address phone number d) alternate contact phone number e) enable the EnhancedMessagingPreferences system preference. check the SMS number under Patron messaging preferences (back on the detail page) is clickable 3) Check to see if there are any phone numbers I have missed. Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Should not we make these links visible/clickable only for mobile devices? (In reply to Jonathan Druart from comment #5) > Should not we make these links visible/clickable only for mobile devices? I can click them from my macbook, it opens up FaceTime I think. I get """ The address wasn't understood Iceweasel doesn't know how to open this address, because one of the following protocols (tel) isn't associated with any program or is not allowed in this context. You might need to install other software to open this address. """ (In reply to Jonathan Druart from comment #5) > Should not we make these links visible/clickable only for mobile devices? Some mobile devices may not need the link and discover that it is a phone number anyway. If you install a app/plugin on your desktop, you can make this work too. Created attachment 50569 [details] [review] Bug 16182: Make phone number clickable to call EDIT: fixing typo, changing sms number from tel: to sms: To test: 1) Go to a patron detail page 2) Confirm that all available phone numbers can be clicked and allow you to call this number from your device a) in the top left circ-menu.inc b) primary/secondary/other/organisation/mobile phone numbers c) alternate address phone number d) alternate contact phone number e) enable the EnhancedMessagingPreferences system preference. check the SMS number under Patron messaging preferences (back on the detail page) is clickable 3) Check to see if there are any phone numbers I have missed. Sponsored-by: Catalyst IT Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master! Should be in the May 2016 release. Danke Aleisha! |