Bug 16215

Summary: Missing closing quote in checkout template
Product: Koha Reporter: Owen Leonard <oleonard>
Component: CirculationAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: brendan, gmcharlt, hector.hecaxmmx, jonathan.druart, julian.maurice, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/circ/circulation.pl?borrowernumber=X
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 15821    
Bug Blocks:    
Attachments: Bug 16215 - Missing closing quote in checkout template
[SIGNED-OFF]Bug 16215: Missing closing quote in checkout template
Bug 16215: Missing closing quote in checkout template

Description Owen Leonard 2016-04-06 14:30:11 UTC
There is a missing closing quote in circulation.tt on line 411:

<button type="submit" class="deny"><i class="fa fa-times></i> Continue</button>
Comment 1 Owen Leonard 2016-04-06 14:41:26 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-04-06 15:56:47 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-04-06 16:46:35 UTC
Created attachment 50001 [details] [review]
Bug 16215: Missing closing quote in checkout template

This patch adds a missing closing quote to the circulation template.

To see the affect of this bug:

- Log in to Koha with an account which does not have the
  'force_checkout' permission.
- Locate a barcode which is checked out to a patron.
- Open a different patron account for checkout.
- Try to check out the barcode to that different patron.

You see a "Cannot check out" dialog which breaks the structure of the
rest of the page.

To test, apply the patch and repeat the steps above. The issue should be
fixed.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-04-06 22:02:10 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 5 Julian Maurice 2016-04-07 05:22:04 UTC
Not needed in stable versions, status changed to RESOLVED