Description
Owen Leonard
2016-04-11 17:16:53 UTC
Created attachment 50129 [details] [review] Bug 16241 - Move staff client CSS out of language directory The staff client CSS is not language-specific, so it can be moved out of the en/ directory and thus not be duplicated for every translation. In order to be able to have a generic path to the YUI CSS files, the YUI directory is moved by this patch to the staff client's lib/ directory. To test, apply the patch and visit various pages in the staff client. Look in particular at pages which include more than the standard CSS. For example: - The staff client home page. - Patron -> Set permissions. - The advanced cataloging editor. - Acquisitions -> Vendor -> Basket groups. - Tools -> News -> Edit news. - Administration -> System preferences. Created attachment 50155 [details] [review] Bug 16241 - Move staff client CSS out of language directory The staff client CSS is not language-specific, so it can be moved out of the en/ directory and thus not be duplicated for every translation. In order to be able to have a generic path to the YUI CSS files, the YUI directory is moved by this patch to the staff client's lib/ directory. To test, apply the patch and visit various pages in the staff client. Look in particular at pages which include more than the standard CSS. For example: - The staff client login page. - The staff client home page. - Patron -> Set permissions. - The advanced cataloging editor. - Acquisitions -> Vendor -> Basket groups. - Tools -> News -> Edit news. - Administration -> System preferences. Revised: I intended for this to be built on top of Bug 15883. Now it is. Created attachment 50469 [details] [review] [SIGNED-OFF] Bug 16241 - Move staff client CSS out of language directory The staff client CSS is not language-specific, so it can be moved out of the en/ directory and thus not be duplicated for every translation. In order to be able to have a generic path to the YUI CSS files, the YUI directory is moved by this patch to the staff client's lib/ directory. To test, apply the patch and visit various pages in the staff client. Look in particular at pages which include more than the standard CSS. For example: - The staff client login page. - The staff client home page. - Patron -> Set permissions. - The advanced cataloging editor. - Acquisitions -> Vendor -> Basket groups. - Tools -> News -> Edit news. - Administration -> System preferences. Revised: I intended for this to be built on top of Bug 15883. Now it is. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of 15883 Works as described, all pages on test plan No Errors Overall this looks good, but I found a few files that refer en/css still: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt:<link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/en/css/datatables.css" /> koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt:<link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/en/css/datatables.css" /> koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt:<link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/en/css/datatables.css" /> koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARC_compact.xsl: <link href="/koha-tmpl/opac-tmpl/prog/en/css/xsl.css" rel="stylesheet" type="text/css" /> Created attachment 50630 [details] [review] Bug 16241 - Move staff client CSS out of language directory This patch corrects CSS paths in three places I missed. To test, apply this follow-up and: - View the patron detail page. DataTables should be styled correctly. - View the tag review page. DataTables should be styled correctly. - From the tag review page, click any tag to see a list of titles with that tag. The DataTable on that page should be styled correctly. Created attachment 50643 [details] [review] [SIGNED-OFF]Bug 16241: Move staff client CSS out of language directory This patch corrects CSS paths in three places I missed. To test, apply this follow-up and: - View the patron detail page. DataTables should be styled correctly. - View the tag review page. DataTables should be styled correctly. - From the tag review page, click any tag to see a list of titles with that tag. The DataTable on that page should be styled correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as expected Created attachment 50659 [details] [review] [PASSED QA] Bug 16241 - Move staff client CSS out of language directory The staff client CSS is not language-specific, so it can be moved out of the en/ directory and thus not be duplicated for every translation. In order to be able to have a generic path to the YUI CSS files, the YUI directory is moved by this patch to the staff client's lib/ directory. To test, apply the patch and visit various pages in the staff client. Look in particular at pages which include more than the standard CSS. For example: - The staff client login page. - The staff client home page. - Patron -> Set permissions. - The advanced cataloging editor. - Acquisitions -> Vendor -> Basket groups. - Tools -> News -> Edit news. - Administration -> System preferences. Revised: I intended for this to be built on top of Bug 15883. Now it is. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of 15883 Works as described, all pages on test plan No Errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 50660 [details] [review] [PASSED QA] Bug 16241: Move staff client CSS out of language directory This patch corrects CSS paths in three places I missed. To test, apply this follow-up and: - View the patron detail page. DataTables should be styled correctly. - View the tag review page. DataTables should be styled correctly. - From the tag review page, click any tag to see a list of titles with that tag. The DataTable on that page should be styled correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for the 16.05 release. Thanks Owen! |