In the staff client, the prog/en/js directory doesn't need to be duplicated for each translation since JavaScript files are not translated. These files should be moved to prog/js.
Created attachment 50130 [details] [review] Bug 16242 - Move staff client JavaScript out of language directory This patch moves the JavaScript files in prog/en/js to prog/js. JavaScript files do not need to be in the directory which is processed by the translator. To test, apply the patch and visit various pages in the staff client to confirm that JavaScript files are still loading correctly.
Created attachment 50156 [details] [review] Bug 16242 - Move staff client JavaScript out of language directory This patch moves the JavaScript files in prog/en/js to prog/js. JavaScript files do not need to be in the directory which is processed by the translator. To test, apply the patch and visit various pages in the staff client to confirm that JavaScript files are still loading correctly. Revised: I intended for this to be built on top of Bug 15883 as well as Bug 16242. Now it is.
Created attachment 50470 [details] [review] [SIGNED-OFF] Bug 16242 - Move staff client JavaScript out of language directory This patch moves the JavaScript files in prog/en/js to prog/js. JavaScript files do not need to be in the directory which is processed by the translator. To test, apply the patch and visit various pages in the staff client to confirm that JavaScript files are still loading correctly. Revised: I intended for this to be built on top of Bug 15883 as well as Bug 16242. Now it is. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of 15883 and 16241 All seems to work, js files pulled from new dir. No errors
Hi Owen, I found a broken page: koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt:<script type="text/javascript" src="[% interface %]/prog/en/js/offlinecirc.js"></script> Can you please provide a follow-up?
Created attachment 50629 [details] [review] Bug 16242 [Follow-up] Move staff client JavaScript out of language directory Correcting to a file I missed: circ/offline.tt. This patch corrects the path to offlinecirc.js. To test, go to Circulation -> Built-in offline circulation interface. There should be no errors in the console warning of missing files. The "Check out" link should work correctly.
Hi Owen Please rebase patches Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 16242 - Move staff client JavaScript out of language directory When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort".
Hi, did you apply the dependent bug first?
Ohh Uppss noup Sorry for my mistake
Created attachment 50642 [details] [review] Bug 16242 [Follow-up] Move staff client JavaScript out of language directory Correcting to a file I missed: circ/offline.tt. This patch corrects the path to offlinecirc.js. To test, go to Circulation -> Built-in offline circulation interface. There should be no errors in the console warning of missing files. The "Check out" link should work correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> File missed was fixed
Created attachment 50661 [details] [review] [PASSED QA] Bug 16242 - Move staff client JavaScript out of language directory This patch moves the JavaScript files in prog/en/js to prog/js. JavaScript files do not need to be in the directory which is processed by the translator. To test, apply the patch and visit various pages in the staff client to confirm that JavaScript files are still loading correctly. Revised: I intended for this to be built on top of Bug 15883 as well as Bug 16242. Now it is. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of 15883 and 16241 All seems to work, js files pulled from new dir. No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 50664 [details] [review] [PASSED QA] Bug 16242 [Follow-up] Move staff client JavaScript out of language directory Correcting to a file I missed: circ/offline.tt. This patch corrects the path to offlinecirc.js. To test, go to Circulation -> Built-in offline circulation interface. There should be no errors in the console warning of missing files. The "Check out" link should work correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> File missed was fixed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for the 16.05 release. Thanks Owen!