Bug 16288

Summary: Edifact sysprefs EDIfactEAN and EDIInvoicesShippingBudget problems
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: Architecture, internals, and plumbingAssignee: Colin Campbell <colin.campbell>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: colin.campbell, julian.maurice, kyle, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 7736    
Bug Blocks:    
Attachments: Proposed patch
Proposed patch
Bug 16288: Remove Reference to obsolete EAN syspref
Bug 16288: Remove unused EDI Shipping Budget syspref
Bug 16288: (QA followup) Remove the syspref INSERT line
Bug 16288: Remove Reference to obsolete EAN syspref
Bug 16288: Remove unused EDI Shipping Budget syspref
Bug 16288: (QA followup) Remove the syspref INSERT line
Bug 16288: Remove EDIInvoicesShippingBudget for devs

Description Tomás Cohen Arazi (tcohen) 2016-04-18 19:00:04 UTC
Bug 7736 introduced this two problematic sysprefs:

EDIInvoicesShippingBudget:

* sysprefs.sql: YAY!
* updatedatabase.pl: YAY!
* acquisitions.pref: BOOOOO, missing
* The syspref is not actually used:
To reproduce:
- Run
  $ git grep EDIInvoicesShippingBudget
=> FAIL: Only shows in sysprefs.sql and updatedatabase.pl

EDIfactEAN:

* sysprefs.sql: BOOOOO, missing
* updatedatabase.pl: BOOOOO, missing
* acquisitions.pref: BOOOOO, missing
* The syspref is actually used:
To reproduce:
- Run
  $ git grep EDIfactEAN
=> FAIL: The not-introduced syspref is actually used:
Koha/EDI.pm:    $ean ||= C4::Context->preference('EDIfactEAN');
Comment 1 Colin Campbell 2016-05-13 09:20:50 UTC Comment hidden (obsolete)
Comment 2 Colin Campbell 2016-05-13 09:21:55 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi (tcohen) 2016-05-13 13:08:46 UTC Comment hidden (obsolete)
Comment 4 Tomás Cohen Arazi (tcohen) 2016-05-13 13:08:54 UTC Comment hidden (obsolete)
Comment 5 Tomás Cohen Arazi (tcohen) 2016-05-13 13:09:02 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2016-05-16 11:06:35 UTC
Created attachment 51518 [details] [review]
Bug 16288: Remove Reference to obsolete EAN syspref

Remove reference to obsolete syspref EDIfactEAN
which was present in earlier test version of
EDI code but should not now be used

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2016-05-16 11:06:41 UTC
Created attachment 51519 [details] [review]
Bug 16288: Remove unused EDI Shipping Budget syspref

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2016-05-16 11:06:45 UTC
Created attachment 51520 [details] [review]
Bug 16288: (QA followup) Remove the syspref INSERT line

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2016-05-16 11:06:49 UTC
Created attachment 51521 [details] [review]
Bug 16288: Remove EDIInvoicesShippingBudget for devs

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Kyle M Hall (khall) 2016-05-16 17:16:30 UTC
Pushed to master for Koha 16.05, thanks Colin, Tomas!
Comment 11 Julian Maurice 2016-05-16 17:23:53 UTC
Not needed in stable versions, status changed to RESOLVED