Bug 7736 introduced this two problematic sysprefs: EDIInvoicesShippingBudget: * sysprefs.sql: YAY! * updatedatabase.pl: YAY! * acquisitions.pref: BOOOOO, missing * The syspref is not actually used: To reproduce: - Run $ git grep EDIInvoicesShippingBudget => FAIL: Only shows in sysprefs.sql and updatedatabase.pl EDIfactEAN: * sysprefs.sql: BOOOOO, missing * updatedatabase.pl: BOOOOO, missing * acquisitions.pref: BOOOOO, missing * The syspref is actually used: To reproduce: - Run $ git grep EDIfactEAN => FAIL: The not-introduced syspref is actually used: Koha/EDI.pm: $ean ||= C4::Context->preference('EDIfactEAN');
Created attachment 51462 [details] [review] Proposed patch Remove the reference to the EAN syspref
Created attachment 51463 [details] [review] Proposed patch REmove the shipping budget syspref
Created attachment 51466 [details] [review] Bug 16288: Remove Reference to obsolete EAN syspref Remove reference to obsolete syspref EDIfactEAN which was present in earlier test version of EDI code but should not now be used Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 51467 [details] [review] Bug 16288: Remove unused EDI Shipping Budget syspref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 51468 [details] [review] Bug 16288: (QA followup) Remove the syspref INSERT line Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 51518 [details] [review] Bug 16288: Remove Reference to obsolete EAN syspref Remove reference to obsolete syspref EDIfactEAN which was present in earlier test version of EDI code but should not now be used Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 51519 [details] [review] Bug 16288: Remove unused EDI Shipping Budget syspref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 51520 [details] [review] Bug 16288: (QA followup) Remove the syspref INSERT line Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 51521 [details] [review] Bug 16288: Remove EDIInvoicesShippingBudget for devs Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for Koha 16.05, thanks Colin, Tomas!
Not needed in stable versions, status changed to RESOLVED