Summary: | datatables on opac-suggestions.pl broken by js error | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, jonathan.druart, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15044 | ||
Bug Blocks: | |||
Attachments: |
Bug 16328: follow-up for bug 15044 - Fix datatable error
Bug 16328: follow-up for bug 15044 - Fix datatable error [PASSED QA] Bug 16328: follow-up for bug 15044 - Fix datatable error |
Description
Nick Clemens (kidclamp)
2016-04-22 23:44:00 UTC
Bug 15883 shouldn't be related to this but g because it didn't touch the OPAC. Created attachment 50592 [details] [review] Bug 16328: follow-up for bug 15044 - Fix datatable error Bug 15044 added a new column to the suggestion table at the OPAC but forgot to modify the DT params. Test plan: The suggestion table at the OPAC should not be broken with this patch. Created attachment 50598 [details] [review] Bug 16328: follow-up for bug 15044 - Fix datatable error Bug 15044 added a new column to the suggestion table at the OPAC but forgot to modify the DT params. Test plan: The suggestion table at the OPAC should not be broken with this patch. NOTE: Sorting was broken prior to patch. Sorting was fixed after patch. The added null causes the field count to match up properly. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 50600 [details] [review] [PASSED QA] Bug 16328: follow-up for bug 15044 - Fix datatable error Bug 15044 added a new column to the suggestion table at the OPAC but forgot to modify the DT params. Test plan: The suggestion table at the OPAC should not be broken with this patch. NOTE: Sorting was broken prior to patch. Sorting was fixed after patch. The added null causes the field count to match up properly. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 Release. Thanks Not needed in stable versions, status changed to RESOLVED |