Summary: | Buttons wrap in Actions column for reviewing tags | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Tools | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
screenshot showing wrap
Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap [SIGNED-OFF] Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap [PASSED QA] Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap |
Created attachment 50777 [details] [review] Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap To test: 1) Go to Tools -> Tags 2) Click Reject for a tag 3) Notice buttons do not wrap Sponsored-by: Catalyst IT Created attachment 50778 [details] [review] Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap Note: the wrapping only happens when all tags have been approved (or all rejected), i.e. column has a certain width. When testing, ensure all tags have been approved or rejected and click the opposite action to see the effect of the bug and the patch. To test: 1) Go to Tools -> Tags 2) Click Reject for a tag 3) Notice buttons do not wrap Sponsored-by: Catalyst IT I find that the problem also happens when you have tags pending approval. The two buttons display correctly until you click one of them. The <td> at line 267 also needs the "actions" class. Created attachment 50850 [details] [review] Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap EDIT: Comment 3 Note: the wrapping only happens when all tags have been approved (or all rejected), i.e. column has a certain width. When testing, ensure all tags have been approved or rejected and click the opposite action to see the effect of the bug and the patch. To test: 1) Go to Tools -> Tags 2) Click Reject for a tag 3) Notice buttons do not wrap Sponsored-by: Catalyst IT Created attachment 50856 [details] [review] [SIGNED-OFF] Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap EDIT: Comment 3 Note: the wrapping only happens when all tags have been approved (or all rejected), i.e. column has a certain width. When testing, ensure all tags have been approved or rejected and click the opposite action to see the effect of the bug and the patch. To test: 1) Go to Tools -> Tags 2) Click Reject for a tag 3) Notice buttons do not wrap Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 50890 [details] [review] [PASSED QA] Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap EDIT: Comment 3 Note: the wrapping only happens when all tags have been approved (or all rejected), i.e. column has a certain width. When testing, ensure all tags have been approved or rejected and click the opposite action to see the effect of the bug and the patch. To test: 1) Go to Tools -> Tags 2) Click Reject for a tag 3) Notice buttons do not wrap Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master! Should be in the May 2016 release! Dankie Aleisha! |
Created attachment 50776 [details] screenshot showing wrap Look fine when Approved, but wrap when I click Rejected