Bug 16360 - Buttons wrap in Actions column for reviewing tags
Summary: Buttons wrap in Actions column for reviewing tags
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-27 01:34 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
screenshot showing wrap (33.91 KB, image/png)
2016-04-27 01:34 UTC, Aleisha Amohia
Details
Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap (1.39 KB, patch)
2016-04-27 01:37 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap (1.64 KB, patch)
2016-04-27 01:39 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap (2.38 KB, patch)
2016-04-27 21:03 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap (2.48 KB, patch)
2016-04-28 01:10 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap (2.49 KB, patch)
2016-04-28 09:58 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-04-27 01:34:28 UTC
Created attachment 50776 [details]
screenshot showing wrap

Look fine when Approved, but wrap when I click Rejected
Comment 1 Aleisha Amohia 2016-04-27 01:37:35 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-04-27 01:39:52 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2016-04-27 12:43:29 UTC
I find that the problem also happens when you have tags pending approval. The two buttons display correctly until you click one of them. The <td> at line 267 also needs the "actions" class.
Comment 4 Aleisha Amohia 2016-04-27 21:03:44 UTC Comment hidden (obsolete)
Comment 5 Owen Leonard 2016-04-28 01:10:12 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2016-04-28 09:58:53 UTC
Created attachment 50890 [details] [review]
[PASSED QA] Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap

EDIT: Comment 3

Note: the wrapping only happens when all tags have been approved (or all
rejected), i.e. column has a certain width. When testing, ensure all
tags have been approved or rejected and click the opposite
action to see the effect of the bug and the patch.

To test:
1) Go to Tools -> Tags
2) Click Reject for a tag
3) Notice buttons do not wrap

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Kyle M Hall 2016-04-29 10:49:05 UTC
Pushed to master! Should be in the May 2016 release! Dankie Aleisha!