Summary: | Installer syntax error | ||
---|---|---|---|
Product: | Koha | Reporter: | Liz Rea <liz> |
Component: | Installation and upgrade (command-line installer) | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P1 - high | CC: | bgkriegel, julian.maurice, katrin.fischer, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16354 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16361: Installer syntax error
Bug 16361 - syntax error in updatedatabase Bug 16361: Installer syntax error [PASSED QA] Bug 16361: Installer syntax error |
Description
Liz Rea
2016-04-27 02:00:47 UTC
Created attachment 50779 [details] [review] Bug 16361: Installer syntax error Bug 16354 introduces a syntax error on updatedatabase.pl see comment #5 there To test 1) Check error on update 3.23.00.051 2) Apply the patch 3) run updatedabase again (perhaps changing 051 to XXX) Created attachment 50780 [details] [review] Bug 16361 - syntax error in updatedatabase To test: Set version below 3.23.00.051 (if necessary - you can do this in the localuse preferences in the intranet) Run the updatedatabase in your favourite way There should be no errors. Comment on attachment 50780 [details] [review] Bug 16361 - syntax error in updatedatabase You beat me :) Created attachment 50782 [details] [review] Bug 16361: Installer syntax error Bug 16354 introduces a syntax error on updatedatabase.pl see comment #5 there To test 1) Check error on update 3.23.00.051 2) Apply the patch 3) run updatedabase again (perhaps changing 051 to XXX) Signed-off-by: Liz Rea <liz@catalyst.net.nz> happy again! (In reply to Liz Rea from comment #3) > > You beat me :) Yours was prettier :) awww, hugs all around. :) http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4e6baf61858bd22d91d50ad5f176f04242a23370 With this patch we don't get this message, caused by the above patch: [Wed Apr 27 14:50:11 2016] updatedatabase.pl: Not a CODE reference at /home/liz/koha-src/koha/installer/data/mysql/updatedatabase.pl line 12355. (In reply to Liz Rea from comment #7) > http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff; > h=4e6baf61858bd22d91d50ad5f176f04242a23370 > > With this patch we don't get this message, caused by the above patch: > > [Wed Apr 27 14:50:11 2016] updatedatabase.pl: Not a CODE reference at > /home/liz/koha-src/koha/installer/data/mysql/updatedatabase.pl line 12355. Brendan beat us two, and it's pushed :) Resolved -> Fixed? Nope, his one is still broken. :( (In reply to Liz Rea from comment #9) > Nope, his one is still broken. :( Yeap, a missing 'do' Created attachment 50786 [details] [review] [PASSED QA] Bug 16361: Installer syntax error Bug 16354 introduces a syntax error on updatedatabase.pl see comment #5 there To test 1) Check error on update 3.23.00.051 2) Apply the patch 3) run updatedabase again (perhaps changing 051 to XXX) Signed-off-by: Liz Rea <liz@catalyst.net.nz> happy again! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Hi Brendan, we are still missing a 'do' in the last updatedatabase entry: -$dbh->(q{ +$dbh->do(q{ I have passed the patch here - so you can either fix it directly or revert the last commit and use this patch here. Pushed to Master - Should be in the May 2016 Release. Thanks! Not needed in stable versions, status changed to RESOLVED |