Summary: | Remove obsolete "border" attribute from <img> tags | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 16366 - Remove obsolete "border" attribute from <img> tags
Bug 16366 - Remove obsolete "border" attribute from <img> tags [PASSED QA] Bug 16366 - Remove obsolete "border" attribute from <img> tags |
Description
Owen Leonard
2016-04-27 13:31:14 UTC
Created attachment 50810 [details] [review] Bug 16366 - Remove obsolete "border" attribute from <img> tags This patch removes the obsolete "border" attribute from <img> tags. Browsers haven't applied an border to images by default for years. There should be no visible changes as a result of this patch. It only affects HTML validation. If you want to test the affected pages, apply the patch and confirm that images look correct on these pages: - In the patron sidebar menu, if patron images are enabled. - On the authority MARC subfield structure administration page, only some obsolete markup is affected (See Bug 16367). - I don't know how to trigger display of the "filefind.png" image on authority and bibliographic detail pages. Possibly unused markup? - On the advanced search page, itemtype/collection/shelving location images should look correct. - When viewing existing holds for a title, the arrow images used for changing the position of a hold in the list should look correct. - When viewing a list of MARC modification actions, the arrow images used for changing the order of actions should look correct. Testing... - In the patron sidebar menu, if patron images are enabled. OK - On the authority MARC subfield structure administration page, only some obsolete markup is affected (See Bug 16367). OK (compared code in diff) - I don't know how to trigger display of the "filefind.png" image on authority and bibliographic detail pages. Possibly unused markup? OK (compared code in diff) - On the advanced search page, itemtype/collection/shelving location images should look correct. OK - When viewing existing holds for a title, the arrow images used for changing the position of a hold in the list should look correct. OK - When viewing a list of MARC modification actions, the arrow images used for changing the order of actions should look correct. OK Created attachment 50812 [details] [review] Bug 16366 - Remove obsolete "border" attribute from <img> tags This patch removes the obsolete "border" attribute from <img> tags. Browsers haven't applied an border to images by default for years. There should be no visible changes as a result of this patch. It only affects HTML validation. If you want to test the affected pages, apply the patch and confirm that images look correct on these pages: - In the patron sidebar menu, if patron images are enabled. - On the authority MARC subfield structure administration page, only some obsolete markup is affected (See Bug 16367). - I don't know how to trigger display of the "filefind.png" image on authority and bibliographic detail pages. Possibly unused markup? - On the advanced search page, itemtype/collection/shelving location images should look correct. - When viewing existing holds for a title, the arrow images used for changing the position of a hold in the list should look correct. - When viewing a list of MARC modification actions, the arrow images used for changing the order of actions should look correct. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 50833 [details] [review] [PASSED QA] Bug 16366 - Remove obsolete "border" attribute from <img> tags This patch removes the obsolete "border" attribute from <img> tags. Browsers haven't applied an border to images by default for years. There should be no visible changes as a result of this patch. It only affects HTML validation. If you want to test the affected pages, apply the patch and confirm that images look correct on these pages: - In the patron sidebar menu, if patron images are enabled. - On the authority MARC subfield structure administration page, only some obsolete markup is affected (See Bug 16367). - I don't know how to trigger display of the "filefind.png" image on authority and bibliographic detail pages. Possibly unused markup? - On the advanced search page, itemtype/collection/shelving location images should look correct. - When viewing existing holds for a title, the arrow images used for changing the position of a hold in the list should look correct. - When viewing a list of MARC modification actions, the arrow images used for changing the order of actions should look correct. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for the 16.05 release. Thanks Owen! |