Summary: | Perlcritic errors introduced by 12478 | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, hector.hecaxmmx, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 12478 | ||
Bug Blocks: | |||
Attachments: |
Bug 16448: Fix perlcritic errors introduced by 12478
[SIGNED-OFF]Bug 16448: Fix perlcritic errors introduced by 12478 [PASSED QA] Bug 16448: Fix perlcritic errors introduced by 12478 |
Description
Tomás Cohen Arazi (tcohen)
2016-05-05 14:16:48 UTC
Created attachment 51237 [details] [review] Bug 16448: Fix perlcritic errors introduced by 12478 Bug 12478 introduced two perlcritic errors. This patch fixes them. To test: - On master, run: $ prove t/t/00-testcritic.t => FAIL: catalogue/search.pl and Koha/Authority.pm fail the critic tests. - Apply the patch - Run: $ prove t/t/00-testcritic.t => SUCCESS: All happy - Sign off :-D Created attachment 51254 [details] [review] [SIGNED-OFF]Bug 16448: Fix perlcritic errors introduced by 12478 Bug 12478 introduced two perlcritic errors. This patch fixes them. To test: - On master, run: $ prove t/00-testcritic.t => FAIL: catalogue/search.pl and Koha/Authority.pm fail the critic tests. - Apply the patch - Run: $ prove t/00-testcritic.t => SUCCESS: All happy - Sign off :-D Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test successful. Needs $ export TEST_QA=1 Created attachment 51261 [details] [review] [PASSED QA] Bug 16448: Fix perlcritic errors introduced by 12478 Bug 12478 introduced two perlcritic errors. This patch fixes them. To test: - On master, run: $ prove t/00-testcritic.t => FAIL: catalogue/search.pl and Koha/Authority.pm fail the critic tests. - Apply the patch - Run: $ prove t/00-testcritic.t => SUCCESS: All happy - Sign off :-D Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test successful. Needs $ export TEST_QA=1 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 Release. Thanks! Not needed in stable versions, status changed to RESOLVED |