Summary: | ES code incorrectly refers to Moose | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | abl, julian.maurice, jweaver |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 12478 | ||
Bug Blocks: | |||
Attachments: |
Bug 16489: ES code incorrectly refers to Moose
Bug 16489: ES code incorrectly refers to Moose Bug 16489: ES code incorrectly refers to Moose |
Description
Tomás Cohen Arazi (tcohen)
2016-05-10 13:58:29 UTC
Created attachment 51379 [details] [review] Bug 16489: ES code incorrectly refers to Moose Probably a leftover from the original SolR code, there are unused references to Moose in the new Elasticsearch code. To test: - Run: $ git grep Moose => FAIL: There are unneeded references to Moose: Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role; Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role; - Apply the patch - Run: $ git grep Moose => SUCCESS: No references to Moose - Run: $ prove t/Search* t/db_dependent/Search* => SUCCESS: Tests pass - Sign off Created attachment 51381 [details] [review] Bug 16489: ES code incorrectly refers to Moose Probably a leftover from the original SolR code, there are unused references to Moose in the new Elasticsearch code. To test: - Run: $ git grep Moose => FAIL: There are unneeded references to Moose: Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role; Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role; - Apply the patch - Run: $ git grep Moose => SUCCESS: No references to Moose - Run: $ prove t/Search* t/db_dependent/Search* => SUCCESS: Tests pass - Sign off Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Created attachment 51388 [details] [review] Bug 16489: ES code incorrectly refers to Moose Probably a leftover from the original SolR code, there are unused references to Moose in the new Elasticsearch code. To test: - Run: $ git grep Moose => FAIL: There are unneeded references to Moose: Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role; Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role; - Apply the patch - Run: $ git grep Moose => SUCCESS: No references to Moose - Run: $ prove t/Search* t/db_dependent/Search* => SUCCESS: Tests pass - Sign off Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for inclusion in 16.05, to be released in May 2015. Thanks for your work! May 2016, rather... Not needed in stable versions, status changed to RESOLVED |