To reproduce: - Run: $ git grep Moose => FAIL: There are unneeded references to Moose: Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role; Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role;
Created attachment 51379 [details] [review] Bug 16489: ES code incorrectly refers to Moose Probably a leftover from the original SolR code, there are unused references to Moose in the new Elasticsearch code. To test: - Run: $ git grep Moose => FAIL: There are unneeded references to Moose: Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role; Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role; - Apply the patch - Run: $ git grep Moose => SUCCESS: No references to Moose - Run: $ prove t/Search* t/db_dependent/Search* => SUCCESS: Tests pass - Sign off
Created attachment 51381 [details] [review] Bug 16489: ES code incorrectly refers to Moose Probably a leftover from the original SolR code, there are unused references to Moose in the new Elasticsearch code. To test: - Run: $ git grep Moose => FAIL: There are unneeded references to Moose: Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role; Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role; - Apply the patch - Run: $ git grep Moose => SUCCESS: No references to Moose - Run: $ prove t/Search* t/db_dependent/Search* => SUCCESS: Tests pass - Sign off Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
Created attachment 51388 [details] [review] Bug 16489: ES code incorrectly refers to Moose Probably a leftover from the original SolR code, there are unused references to Moose in the new Elasticsearch code. To test: - Run: $ git grep Moose => FAIL: There are unneeded references to Moose: Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role; Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role; - Apply the patch - Run: $ git grep Moose => SUCCESS: No references to Moose - Run: $ prove t/Search* t/db_dependent/Search* => SUCCESS: Tests pass - Sign off Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed for inclusion in 16.05, to be released in May 2015. Thanks for your work!
May 2016, rather...
Not needed in stable versions, status changed to RESOLVED