Summary: | Add the date on which the suggestion was managed on Purchase suggestions tab | ||
---|---|---|---|
Product: | Koha | Reporter: | Marjorie Barry-Vila <marjorie.barry-vila> |
Component: | Patrons | Assignee: | Andreas Roussos <arouss1980> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aholt, arouss1980, gmcharlt, jonathan.druart, kyle.m.hall, patrick.robitaille, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 16535 - Add the date on which the suggestion was managed on Purchase suggestions tab
Bug 16535 - Add the date on which the suggestion was managed on Purchase suggestions tab |
Description
Marjorie Barry-Vila
2016-05-17 13:18:29 UTC
Created attachment 55632 [details] [review] Bug 16535 - Add the date on which the suggestion was managed on Purchase suggestions tab In the Staff client, under Patrons, the 'Purchase suggestions' tab for a patron does not include the date on which the suggestion was managed. If you follow a different route and go to Acquisitions > Suggestions, then the date is shown. This patch adds that enhancement (and fixes an open <td> tag, too). Test plan: 0) [PREREQUISITES] Create a suggestion and manage it, i.e. edit it a bit. 1) Go to Patrons and search for a patron whose suggestion has been managed. In the 'Purchase suggestions' tab for the patron, notice how the third column only lists _who_ managed the suggestion but not _when_. 2) Apply the patch. 3) Repeat step 1). The date the suggestion was managed should be displayed. Created attachment 55894 [details] [review] Bug 16535 - Add the date on which the suggestion was managed on Purchase suggestions tab In the Staff client, under Patrons, the 'Purchase suggestions' tab for a patron does not include the date on which the suggestion was managed. If you follow a different route and go to Acquisitions > Suggestions, then the date is shown. This patch adds that enhancement (and fixes an open <td> tag, too). Test plan: 0) [PREREQUISITES] Create a suggestion and manage it, i.e. edit it a bit. 1) Go to Patrons and search for a patron whose suggestion has been managed. In the 'Purchase suggestions' tab for the patron, notice how the third column only lists _who_ managed the suggestion but not _when_. 2) Apply the patch. 3) Repeat step 1). The date the suggestion was managed should be displayed. Signed-off-by: Marc Véron <veron@veron.ch> I think it would be better to add this info to its own column to allow sort on it, don't you think? (In reply to Jonathan Druart from comment #3) > I think it would be better to add this info to its own column to allow sort > on it, don't you think? Hum not sure actually, it's how it's displayed on the suggestion list page. (In reply to Jonathan Druart from comment #4) > (In reply to Jonathan Druart from comment #3) > > I think it would be better to add this info to its own column to allow sort > > on it, don't you think? > > Hum not sure actually, it's how it's displayed on the suggestion list page. The way the patch displays the date is fine for me. A date colum would be fine as well, but if we add a date column, we should do the same on the suggestion list page to have the same look & feel. I think the addition of a new column for the date would be a good change. If we want to stick with this patch, we should fix the following bug: If the date does not exist, the cell contains: "name - " (In reply to Jonathan Druart from comment #7) > If we want to stick with this patch, we should fix the following bug: > If the date does not exist, the cell contains: "name - " Can that ever happen? I had to delete the date directly in mysql to test this case (setting the date to '' and to NULL). If there is no date, the column displays nothing (with and without patch). On /suggestion/suggestion.pl, the column shows ' - ' (no name, no date, only the -) But if somebody adds a date column, I'll be happy to sign off :-) I have plenty of them and the check exist in suggestion.tt Our staff would love a sortable column for date managed and date suggested in the borrower view. Hopefully this is still a possibility! |