When looking a specific patrons suggestions from pat_purchase_suggestions.tt it would be nice if there were columns for 'Managed on' date and 'Suggested on' date which could sort by these dates.
Created attachment 98421 [details] [review] Bug 24585: Add suggested on/managed on columns This patch adds 2 new columns on the suggestions table on purchase-suggestions.tt. These use the data-order attribute to allow for sorting. TEST PLAN: 1. Have a patron with some suggestions that have been managed by staff. (accept or reject the request). 2. View that patrons suggestions from purchase-suggestions.pl. 3. No suggested on or managaed on columns. 4. Apply patch and reload the page. 5. The new columns are there, have multiple suggestions and make sure sorting by the date works.
Hi Lucas, can you please update your patch to include a bug description and test plan? I think you might have done it in the git bz attach step - but that doesn't change the patch file itself and it's still empty.
I'll usually just do it - but I noticed it happens quite often now, so trying to get to the root of the issue :)
Created attachment 98483 [details] [review] Bug 24585: Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt This patch adds 2 new columns on the suggestions table on purchase-suggestions.tt. These use the data-order attribute to allow for sorting. TEST PLAN: 1. Have a patron with some suggestions that have been managed by staff. (accept or reject the request). 2. View that patrons suggestions from purchase-suggestions.pl. 3. No suggested on or managaed on columns. 4. Apply patch and reload the page. 5. The new columns are there, have multiple suggestions and make sure sorting by the date works.
Created attachment 98621 [details] [review] Bug 24585: Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt This patch adds 2 new columns on the suggestions table on purchase-suggestions.tt. These use the data-order attribute to allow for sorting. TEST PLAN: 1. Have a patron with some suggestions that have been managed by staff. (accept or reject the request). 2. View that patrons suggestions from purchase-suggestions.pl. 3. No suggested on or managaed on columns. 4. Apply patch and reload the page. 5. The new columns are there, have multiple suggestions and make sure sorting by the date works. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I can see in bug history, that this was switched to signed off by shumi78@gmail.com, but there is no sign-off line/comment. As this is a easy to read/test template change, I think PQA is ok with or without the SO.
Nice work everyone! Pushed to master for 20.05
Enhancement not pushed to 19.11.x
*** Bug 16535 has been marked as a duplicate of this bug. ***