|
Description
Marc Véron
2016-05-18 04:26:47 UTC
Additional issue: <p>If you want to, you can try to <a href="/cgi-bin/koha/svc/auth/googleopenidconnect?reauthenticate=select_account">log in using a different account</a> Created attachment 51735 [details] [review] Bug 16540: Translatability in opac-auth.tt (tag-splitted sentences) This patch removes tag-splitting from 2 sentences in pac-auth.tt To test: - Review code changes and verify that sentences ar no longer splitted Created attachment 51776 [details] [review] Bug 16540: Translatability in opac-auth.tt (tag-splitted sentences) This patch removes tag-splitting from 2 sentences in pac-auth.tt To test: - Review code changes and verify that following sentences are no longer splitted by <a>-tags: "Logout and try again with a different user" "Try to log in using a different Google account" UPDATE: Amended to fix a tiny typo Created attachment 51911 [details] [review] [SIGNED-OFF] Bug 16540: Translatability in opac-auth.tt (tag-splitted sentences) This patch removes tag-splitting from 2 sentences in pac-auth.tt To test: - Review code changes and verify that following sentences are no longer splitted by <a>-tags: "Logout and try again with a different user" "Try to log in using a different Google account" UPDATE: Amended to fix a tiny typo Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Just a dumb question: But don't we have other (easy) ways to achieve the same? Just hope so. Now, we end up with large clickable texts (read: <a> tags).. (In reply to Marcel de Rooy from comment #5) > Just a dumb question: > But don't we have other (easy) ways to achieve the same? Just hope so. > Now, we end up with large clickable texts (read: <a> tags).. I considered to have something like having an unlinked text as explanation followed by a link, something like: "Logout and try again with a different user. <a..>Click here</>" ... but I do not think that that would be nicer. Anyway, I agree with every solution that does not lead to messy / incorrect translations. There are more issues, opac-auth.tt lines 90 and following. I went through the file to locate more translation issues. The current indentation makes it difficult to read. That's why I'll try to clean up indentation as well. Otherwise it is difficult to be sure that changes do not have unwanted side effects. Created attachment 51945 [details] [review] Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. I see one typo: "<p>If you have a CAS account, please please choose against which one you would like to authenticate:</p>" There is an extra "please." As long as we are making changes to this page, I have a couple of other suggestions: - "Logout and try again with a different user" should use "Log out" instead. - "If you have a Shibboleth account, please click here to login." should use "log in" instead of "login." - "<p><a href="[% casServerUrl %]">Please click here to login.</a><p>" Use "log in" instead. - "<p><a href="[% casServerUrl %]">If you have a CAS account, please click here to login.</a><p>" Use "log in" instead. I looked for guidance for this on the terminology page on the wiki (https://wiki.koha-community.org/wiki/Terminology) and could not find it, but in my opinion it is analogous to this rule: "Use 'checkout' as a noun, 'check out' as a verb." Created attachment 51950 [details] [review] Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. UPDATE: Amended for comment #10 / mv Created attachment 51951 [details] [review] [SIGNED-OFF] Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. UPDATE: Amended for comment #10 / mv Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 52154 [details] [review] Bug 16540 - Clean up opac-auth.tt for translatability This patch fixes translatability issues in opac-auth.tt (ugly translations caused by sentence splitting). It was necessary to change indentation to make the the file more readable and to make sure that changes have no side effects. The changes do not touch the overall functionallity. To test: - Review code to verify that no functionality change is introduced and to verify that the text changes make sense. - Apply patch, verify that OPAC login page behaves as before. UPDATE: Amended for comment #10 / mv Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for Koha 16.11, thanks Marc! Pushed in 16.05. Will be in 16.05.01. Patch pushed to 3.22.x, will be in 3.22.8 |