Bug 16560

Summary: Translatability: Issues in opac-memberentry.tt
Product: Koha Reporter: Marc Véron <veron>
Component: I18N/L10NAssignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: f.demians, julian.maurice, kyle
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 14659    
Bug Blocks:    
Attachments: Bug 16560: Translatability: Issues with "The entered " in opac-memberentry.tt
Bug 16560: Translatability: Issues with "The entered " in opac-memberentry.tt
Bug 16560: Translatability: Issues with "The entered " in opac-memberentry.tt

Description Marc Véron 2016-05-21 07:36:28 UTC
In opac-memberentry.tt, the following parts lead to translaiton errors because of sentence splitting by tags:

<strong>The entered <a href="#borrower_cardnumber">card number</a> is the wrong length.</strong>

<strong>The entered <a href="#borrower_cardnumber">card number</a> is already in use.</strong>
Comment 1 Marc Véron 2016-05-23 12:27:51 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2016-05-28 09:20:40 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-06-10 15:21:52 UTC
Created attachment 52245 [details] [review]
Bug 16560: Translatability: Issues with "The entered " in opac-memberentry.tt

This patch fixes two splitted sentences to avoid translation issues:

The entered <a href="#borrower_cardnumber">card number</a> is the wrong length.
The entered <a href="#borrower_cardnumber">card number</a> is already in use.

To test:
Apply patch and verify that html in the 2 that are changed is correct and that
they are not splitted by a-tags.

Note: I could not figure out under which conditions this code displays in
      the OPAC self registration form.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Kyle M Hall 2016-06-10 17:38:27 UTC
Pushed to master for 16.11, thanks Marc!
Comment 5 Frédéric Demians 2016-06-15 07:47:02 UTC
Pushed in 16.05. Will be in 16.05.01.
Comment 6 Julian Maurice 2016-06-16 09:19:50 UTC
Not needed in 3.22.x