Both will be hidden by default, via PatronSelfModificationBorrowerUnwantedField (see bug 14658). Also, they will be read only for existing patrons (as cardnumber is currently).
Created attachment 42252 [details] [review] Bug 14659: Allow patrons to enter card number and patron category on OPAC registration page Test plan: 1. Open OPAC self-registration page while logged out. 2. Note that cardnumber and categorycode are not shown. 3. Remove cardnumber and categorycode from PatronSelfRegistrationBorrowerUnwantedField. 4. Enable autoMemberNum. 5. Reload self-registration page, note that categorycode now shows. 6. Disable autoMemberNum. 7. Reload self-registration page, note that cardnumber now shows. 8. Try saving a patron with an existing cardnumber; this should fail and explain why. 9. Set CardnumberLength, and verify that those length restrictions are enforced. 10. Verify that patron can be created with custom categorycode and cardnumber.
Created attachment 43042 [details] [review] Bug 14659: Allow patrons to enter card number and patron category on OPAC registration page Test plan: 1. Open OPAC self-registration page while logged out. 2. Note that cardnumber and categorycode are not shown. 3. Remove cardnumber and categorycode from PatronSelfRegistrationBorrowerUnwantedField. 4. Enable autoMemberNum. 5. Reload self-registration page, note that categorycode now shows. 6. Disable autoMemberNum. 7. Reload self-registration page, note that cardnumber now shows. 8. Try saving a patron with an existing cardnumber; this should fail and explain why. 9. Set CardnumberLength, and verify that those length restrictions are enforced. 10. Verify that patron can be created with custom categorycode and cardnumber. Signed-off-by: Michael Sauers <msauers@dospace.org>
Hm, we need 14658 first here. Please unblock when the patch for 14658 is in the QA queue again.
Comment on attachment 43042 [details] [review] Bug 14659: Allow patrons to enter card number and patron category on OPAC registration page Review of attachment 43042 [details] [review]: ----------------------------------------------------------------- ::: Koha/Template/Plugin/Categories.pm @@ +26,5 @@ > +sub GetName { > + my ( $self, $categorycode ) = @_; > + > + my $schema = Koha::Database->new->schema; > + return $schema->resultset( 'Category' )->search( { Please use Koha::Patron::Categories->find instead.
Created attachment 48376 [details] [review] Bug 14659: Allow patrons to enter card number and patron category on OPAC registration page Test plan: 1. Open OPAC self-registration page while logged out. 2. Note that cardnumber and categorycode are not shown. 3. Remove cardnumber and categorycode from PatronSelfRegistrationBorrowerUnwantedField. 4. Enable autoMemberNum. 5. Reload self-registration page, note that categorycode now shows. 6. Disable autoMemberNum. 7. Reload self-registration page, note that cardnumber now shows. 8. Try saving a patron with an existing cardnumber; this should fail and explain why. 9. Set CardnumberLength, and verify that those length restrictions are enforced. 10. Verify that patron can be created with custom categorycode and cardnumber. Signed-off-by: Michael Sauers <msauers@dospace.org> Rebased.
Created attachment 48377 [details] [review] Bug 14659: (QA followup) switch to using Koha::Patron::Categories Also, fix a nonsensically switched IF/ELSE.
The cardnumber is not displayed anymore on opac-memberentry on the personal details page.
Created attachment 48480 [details] [review] Bug 14659: (QA followup) show cardnumber for existing borrowers This would be incorrectly hidden when autoMemberNum is on. Jonathan, I believe this was probably the issue.
Created attachment 48505 [details] [review] Bug 14659: Allow patrons to enter card number and patron category on OPAC registration page Test plan: 1. Open OPAC self-registration page while logged out. 2. Note that cardnumber and categorycode are not shown. 3. Remove cardnumber and categorycode from PatronSelfRegistrationBorrowerUnwantedField. 4. Enable autoMemberNum. 5. Reload self-registration page, note that categorycode now shows. 6. Disable autoMemberNum. 7. Reload self-registration page, note that cardnumber now shows. 8. Try saving a patron with an existing cardnumber; this should fail and explain why. 9. Set CardnumberLength, and verify that those length restrictions are enforced. 10. Verify that patron can be created with custom categorycode and cardnumber. Signed-off-by: Michael Sauers <msauers@dospace.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48506 [details] [review] Bug 14659: (QA followup) switch to using Koha::Patron::Categories Also, fix a nonsensically switched IF/ELSE. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48507 [details] [review] Bug 14659: (QA followup) show cardnumber for existing borrowers This would be incorrectly hidden when autoMemberNum is on. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 Release.