Summary: | Plack: Use to_app to remove warning about Plack::App::CGIBin instance | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | f.demians, jonathan.druart, julian.maurice, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 16733 | ||
Attachments: |
Bug 16644: Plack: Use to_app to remove warning about Plack::App::CGIBin instance
Bug 16644: Plack: Use to_app to remove warning about Plack::App::CGIBin instance Bug 16644: Plack: Use to_app to remove warning about Plack::App::CGIBin instance |
Description
Marcel de Rooy
2016-06-03 09:39:04 UTC
Note: Running this under Wheezy. Created attachment 51979 [details] [review] Bug 16644: Plack: Use to_app to remove warning about Plack::App::CGIBin instance Using Plack with the debian psgi file, I get lots of warnings like: WARNING: Automatically converting Plack::App::CGIBin instance to a PSGI code reference. If you see this warning for each request, you probably need to explicitly call to_app() i.e. Plack::App::CGIBin->new(...)->to_app in your PSGI file. This patch is aimed to eliminate the warns. Test plan: Run Plack with plack.psgi or koha.psgi and verify if you do not see these warnings anymore. Created attachment 52258 [details] [review] Bug 16644: Plack: Use to_app to remove warning about Plack::App::CGIBin instance Using Plack with the debian psgi file, I get lots of warnings like: WARNING: Automatically converting Plack::App::CGIBin instance to a PSGI code reference. If you see this warning for each request, you probably need to explicitly call to_app() i.e. Plack::App::CGIBin->new(...)->to_app in your PSGI file. This patch is aimed to eliminate the warns. Test plan: Run Plack with plack.psgi or koha.psgi and verify if you do not see these warnings anymore. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 52725 [details] [review] Bug 16644: Plack: Use to_app to remove warning about Plack::App::CGIBin instance Using Plack with the debian psgi file, I get lots of warnings like: WARNING: Automatically converting Plack::App::CGIBin instance to a PSGI code reference. If you see this warning for each request, you probably need to explicitly call to_app() i.e. Plack::App::CGIBin->new(...)->to_app in your PSGI file. This patch is aimed to eliminate the warns. Test plan: Run Plack with plack.psgi or koha.psgi and verify if you do not see these warnings anymore. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I tested on Jessie and I see no regressions. (In reply to Tomás Cohen Arazi from comment #4) > Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > I tested on Jessie and I see no regressions. Thx Pushed to master for 16.11, thanks Marcel! Pushed in 16.05. Will be in 16.05.02. Patch pushed to 3.22.x, will be in 3.22.10 |