Hie, 

I'd say it depends on Bug 15809 directly no ?

+ no warnings 'redefine'; 	
This is already set a few lines above.
No ?

+ use warnings 'redefine';
sure we need this line ?

(In reply to Fridolin SOMERS from comment #2)
> Hie, 
> 
> I'd say it depends on Bug 15809 directly no ?

Yes it does. But that has been pushed some time ago already.

(In reply to Fridolin SOMERS from comment #3)
> + no warnings 'redefine'; 	
> This is already set a few lines above.
> No ?
> 
> + use warnings 'redefine';
> sure we need this line ?

No warnings was repeated. Will remove it and move the enable warns one level higher outside the if statement. It is better to add it. Only allow redefines without warnings within the section you have explicitly marked as such.

Created attachment 53161 [details] [review]
Bug 16645: Plack: Add the multi_param fix from Context in koha.psgi

When you are running koha.psgi (under Wheezy with an older CGI),
you will crash on multi_param calls (e.g. when searching in opac).

This patch simply copies the fix from Context to koha.psgi.

Test plan:
Run Plack with koha.psgi and test searching in opac.

Note that debian scripts work with plack only since jessie

I'm testing :

With the patch I get this warn :

Subroutine _input_cgi_parse redefined at /home/koha/src/opac/opac-search.pl line 527.

Is it plack-specific ?

(In reply to Fridolin SOMERS from comment #8)
> I'm testing :
> 
> With the patch I get this warn :
> 
> Subroutine _input_cgi_parse redefined at /home/koha/src/opac/opac-search.pl
> line 527.
> 
> Is it plack-specific ?

I am not seeing it in my log btw. How can I reproduce?
Could be consequence of enabling the warnings again?

(In reply to Marcel de Rooy from comment #9)
> Could be consequence of enabling the warnings again?

I'd say yes

Closing this report. We are not supporting Wheezy anymore and there is no interest in this patch.