Summary: | Add the possibility to search for multiple branches (libraries) or groups in the advanced search in the opac and the staff interface | ||
---|---|---|---|
Product: | Koha | Reporter: | Gaetan Boisson <gaetan.boisson> |
Component: | Searching | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 16659: Add the possibility to search for multiple branches
[SIGNED OFF] Bug 16659: Add the possibility to search for multiple branches |
Description
Gaetan Boisson
2016-06-04 07:52:12 UTC
Created attachment 52029 [details] [review] Bug 16659: Add the possibility to search for multiple branches At the moment, in advanced search it is possible to pre-select a library to filter results on. However we can only select one library at a time. This patch will allow users to select multiple libraries. This patch replaces the dropdown list of libraries with inputs to make several libraries searchable. Note that this patch is a bit ugly and is only for demo purpose. And also only work on the intranet interface. Test plan: 1/ Go to the adv search form 2/ Select 1 or more libraries ticking the checkboxes 3/ Make sure the results are consistent. 4/ When 1 or more checkboxes are checked, the dropdown list of group of libraries should be disabled It's great works perfectly! Created attachment 52030 [details] [review] [SIGNED OFF] Bug 16659: Add the possibility to search for multiple branches At the moment, in advanced search it is possible to pre-select a library to filter results on. However we can only select one library at a time. This patch will allow users to select multiple libraries. This patch replaces the dropdown list of libraries with inputs to make several libraries searchable. Note that this patch is a bit ugly and is only for demo purpose. And also only work on the intranet interface. Test plan: 1/ Go to the adv search form 2/ Select 1 or more libraries ticking the checkboxes 3/ Make sure the results are consistent. 4/ When 1 or more checkboxes are checked, the dropdown list of group of libraries should be disabled Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com> Comment on attachment 52030 [details] [review] [SIGNED OFF] Bug 16659: Add the possibility to search for multiple branches Review of attachment 52030 [details] [review]: ----------------------------------------------------------------- Patch is a good start, but... ::: catalogue/search.pl @@ +406,5 @@ > +my @branch = map uri_unescape($_), $cgi->multi_param('branch'); > +if( @branch ) { > + push @limits, '(' . join (" or ", map {'branch: ' . $_ } @branch ) . ')'; > +} > + You should do this differently... some comment with good reasons and helpful ... |