Summary: | Fix t/Ris.t (follow-up for 16442) | ||
---|---|---|---|
Product: | Koha | Reporter: | Mirko Tietgen <mirko> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, gmcharlt, julian.maurice, kyle, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 16442 | ||
Bug Blocks: | |||
Attachments: |
Bug 16668 - Move t/Ris.t to t/db_dependent/Ris.t
[SIGNED-OFF] Bug 16668 - Move t/Ris.t to t/db_dependent/Ris.t Bug 16668: Fix t/Ris.t tests Bug 16668: Fix t/Ris.t tests |
Created attachment 52064 [details] [review] Bug 16668 - Move t/Ris.t to t/db_dependent/Ris.t Move test to db_dependent Created attachment 52065 [details] [review] [SIGNED-OFF] Bug 16668 - Move t/Ris.t to t/db_dependent/Ris.t Move test to db_dependent Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Apart from some warnings generated from used modules, this test does not (yet) need the database. With some advanced mocking you might get rid of them. If you just point KOHA_CONF to the original clone's koha-conf, you will have no warnings (and no db access). Created attachment 52123 [details] [review] Bug 16668: Fix t/Ris.t tests Caused by bug 16442. Now we need to mock the marcflavour pref Test plan: prove t/Ris.t should return green Created attachment 52124 [details] [review] Bug 16668: Fix t/Ris.t tests Caused by bug 16442. Now we need to mock the marcflavour pref Test plan: prove t/Ris.t should return green Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Taking the liberty to set to PQA: trivial fix for 16442 just pushed. *** Bug 16674 has been marked as a duplicate of this bug. *** Pushed to master for 16.11, thanks Jonathan! Pushed in 16.05. Will be in 16.05.01. Patch pushed to 3.22.x, will be in 3.22.8 |
> DBI connect('database=koha;host=localhost;port=3306','kohaadmin',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1249 Moving the test to db_dependent