| Summary: | remove two broken test from t/Ris.t | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Galen Charlton <gmcharlt> | 
| Component: | Test Suite | Assignee: | Chris Cormack <chris> | 
| Status: | RESOLVED DUPLICATE | QA Contact: | Galen Charlton <gmcharlt> | 
| Severity: | normal | ||
| Priority: | P5 - low | CC: | hector.hecaxmmx, jonathan.druart | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16668 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: | Bug 16674: remove two tests from t/Ris.t [SIGNED-OFF]Bug 16674: remove two tests from t/Ris.t | ||
| 
        
          Description
        
        
          Galen Charlton
        
        
        
        
          2016-06-07 01:58:23 UTC
        
       Created attachment 52108 [details] [review] Bug 16674: remove two tests from t/Ris.t This patch removes two tests that were broken by the patch for bug 16442, thus preventing packages from being build in master. Ordinarily, one would either fix the tests or change the code that broke the tests... but as the tests in question check the return value of routines that do not actually advertise a return value, I've elected to simply remove them. To test ------- [1] Verify that t/Ris.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Created attachment 52198 [details] [review] [SIGNED-OFF]Bug 16674: remove two tests from t/Ris.t This patch removes two tests that were broken by the patch for bug 16442, thus preventing packages from being build in master. Ordinarily, one would either fix the tests or change the code that broke the tests... but as the tests in question check the return value of routines that do not actually advertise a return value, I've elected to simply remove them. To test ------- [1] Verify that t/Ris.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> |