Summary: | Remove unused template subject.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Architecture, internals, and plumbing | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | f.demians, hector.hecaxmmx, jonathan.druart, julian.maurice, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15927 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16742: Remove unused template subject.tt
[SIGNED-OFF]Bug 16742: Remove unused template subject.tt Bug 16742: (follow-up)Remove unused template subject.tt Bug 16742: Remove unused template subject.tt Bug 16742: (follow-up)Remove unused template subject.tt |
Description
Marc Véron
2016-06-15 07:32:54 UTC
(In reply to Marc Véron from comment #0) > It seems that catalogue/subject.tt is never used. As far as I know it hasn't been used since version 1.x. Created attachment 52424 [details] [review] Bug 16742: Remove unused template subject.tt The template koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt is not used and can be removed. To test: - Apply patch - Verify that catalogue/moredetail.pm works as before (go to a biblio with items and click 'Items' in left hand menue) Created attachment 52469 [details] [review] [SIGNED-OFF]Bug 16742: Remove unused template subject.tt The template koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt is not used and can be removed. To test: - Apply patch - Verify that catalogue/moredetail.pl works as before (go to a biblio with items and click 'Items' in left hand menu) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Created attachment 52471 [details] [review] Bug 16742: (follow-up)Remove unused template subject.tt Delete extra useless comment line: "# if its a subject we need to use the subject.tt" Created attachment 52517 [details] [review] Bug 16742: Remove unused template subject.tt The template koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt is not used and can be removed. To test: - Apply patch - Verify that catalogue/moredetail.pl works as before (go to a biblio with items and click 'Items' in left hand menu) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 52518 [details] [review] Bug 16742: (follow-up)Remove unused template subject.tt Delete extra useless comment line: "# if its a subject we need to use the subject.tt" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Hard to say if it's not used by anyone, but it is out-of-sync with other templates and need work anyway. Pushed to master for 16.11, thanks Marc! Pushed in 16.05. Will be in 16.05.02. Patches pushed to 3.22.x, will be in 3.22.10 |