Bug 16742

Summary: Remove unused template subject.tt
Product: Koha Reporter: Marc Véron <veron>
Component: Architecture, internals, and plumbingAssignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: frederic, hector.hecaxmmx, jonathan.druart+koha, julian.maurice, kyle
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15927
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 16742: Remove unused template subject.tt
[SIGNED-OFF]Bug 16742: Remove unused template subject.tt
Bug 16742: (follow-up)Remove unused template subject.tt
Bug 16742: Remove unused template subject.tt
Bug 16742: (follow-up)Remove unused template subject.tt

Description Marc Véron 2016-06-15 07:32:54 UTC
It seems that catalogue/subject.tt is never used. There is a call in catalogue/moredetail.pl line 52 depending on a param 'subject', but catalogue/moredetail.pl is never called with such param.

See also FIXME comment on line 45 and comment 2 in Bug 15927: Catalog -> subject.tt (is this template used?
Comment 1 Owen Leonard 2016-06-15 12:08:34 UTC
(In reply to Marc Véron from comment #0)
> It seems that catalogue/subject.tt is never used.

As far as I know it hasn't been used since version 1.x.
Comment 2 Marc Véron 2016-06-15 12:42:12 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2016-06-16 15:44:18 UTC Comment hidden (obsolete)
Comment 4 Héctor Eduardo Castro Avalos 2016-06-16 15:56:22 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-06-18 14:56:40 UTC
Created attachment 52517 [details] [review]
Bug 16742: Remove unused template subject.tt

The template koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt
is not used and can be removed.

To test:
- Apply patch
- Verify that catalogue/moredetail.pl works as before (go to a
  biblio with items and click 'Items' in left hand menu)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2016-06-18 14:56:46 UTC
Created attachment 52518 [details] [review]
Bug 16742: (follow-up)Remove unused template subject.tt

Delete extra useless comment line:
"# if its a subject we need to use the subject.tt"

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2016-06-18 14:57:48 UTC
Hard to say if it's not used by anyone, but it is out-of-sync with other templates and need work anyway.
Comment 8 Kyle M Hall 2016-06-24 13:08:59 UTC
Pushed to master for 16.11, thanks Marc!
Comment 9 Frédéric Demians 2016-08-01 11:53:04 UTC
Pushed in 16.05. Will be in 16.05.02.
Comment 10 Julian Maurice 2016-08-16 13:10:24 UTC
Patches pushed to 3.22.x, will be in 3.22.10