Summary: | Autocomplete broken on overdues report | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, gmcharlt, koha-bugs, kyle.m.hall, martin.renvoize, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/circ/overdue.pl | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.06
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 22956 | ||
Attachments: |
Bug 16785: Remove Autocomplete from overdues report filter
Bug 16785: Remove Autocomplete from overdues report filter Bug 16785: Remove Autocomplete from overdues report filter Bug 16785: [20.05] Remove Autocomplete from overdues report filter |
Description
Owen Leonard
2016-06-21 11:33:35 UTC
This appears to still be broken - even more than when reported. It appears now that the pull down with options never loads. eferenceError: create_auto_completion_responder is not defined[Learn More] overdue.pl:486:1 (In reply to Katrin Fischer from comment #2) > eferenceError: create_auto_completion_responder is not defined[Learn More] > overdue.pl:486:1 This aspect of it was caused by Bug 19700, but even after reverting that change the original problem still exists. I'm inclined to say this should not be an autocomplete field at all--it should be a regular dropdown. But the script is too much of a tangle for me to figure that out. I'd agree, autocomplete doesn't match how we treat these fields elsewhere, so having a drop down would work better. Created attachment 120972 [details] [review] Bug 16785: Remove Autocomplete from overdues report filter This patch removes code and markup related to an autocomplete input field in the overdues report filter. The autocomplete was intended to enable easy entry of patron attributes, but it's simpler to use a Select2-styled <select> The patch removes circ/ypattrodue-attr-search-authvalue.pl, which was only used on this page and is now obsolete. To test, apply the patch and create at least one patron attribute type which is linked to an authorized value: - Administration -> Authorized values -> New category - Create a new category to test with - Add multiple authorized values under this category - Administration -> Patron attribute types -> New patron attribute type. - Create an attribute which is linked to the authorized value category you created AND which is marked "Searchable." - Go to Circulation -> Overdues. - In the sidebar filter you should see your patron attribute as an option, styled as a Select2 dropdown. - Clicking the dropdown should trigger a list of the authorized values you created above. - Test that the search field at the top of the list works correctly to filter the results. - Test that any repeatable attribute field can be cloned by clicking the "Add" link, and that cloned fields can be removed using the "Delete" links. - Test that cloned fields remain in place after submitting the fitler form, and that any selected entry in a Select2 widget is preselected. *** Bug 28331 has been marked as a duplicate of this bug. *** Created attachment 121019 [details] [review] Bug 16785: Remove Autocomplete from overdues report filter This patch removes code and markup related to an autocomplete input field in the overdues report filter. The autocomplete was intended to enable easy entry of patron attributes, but it's simpler to use a Select2-styled <select> The patch removes circ/ypattrodue-attr-search-authvalue.pl, which was only used on this page and is now obsolete. To test, apply the patch and create at least one patron attribute type which is linked to an authorized value: - Administration -> Authorized values -> New category - Create a new category to test with - Add multiple authorized values under this category - Administration -> Patron attribute types -> New patron attribute type. - Create an attribute which is linked to the authorized value category you created AND which is marked "Searchable." - Go to Circulation -> Overdues. - In the sidebar filter you should see your patron attribute as an option, styled as a Select2 dropdown. - Clicking the dropdown should trigger a list of the authorized values you created above. - Test that the search field at the top of the list works correctly to filter the results. - Test that any repeatable attribute field can be cloned by clicking the "Add" link, and that cloned fields can be removed using the "Delete" links. - Test that cloned fields remain in place after submitting the fitler form, and that any selected entry in a Select2 widget is preselected. Signed-off-by: David Nind <david@davidnind.com> Created attachment 121043 [details] [review] Bug 16785: Remove Autocomplete from overdues report filter This patch removes code and markup related to an autocomplete input field in the overdues report filter. The autocomplete was intended to enable easy entry of patron attributes, but it's simpler to use a Select2-styled <select> The patch removes circ/ypattrodue-attr-search-authvalue.pl, which was only used on this page and is now obsolete. To test, apply the patch and create at least one patron attribute type which is linked to an authorized value: - Administration -> Authorized values -> New category - Create a new category to test with - Add multiple authorized values under this category - Administration -> Patron attribute types -> New patron attribute type. - Create an attribute which is linked to the authorized value category you created AND which is marked "Searchable." - Go to Circulation -> Overdues. - In the sidebar filter you should see your patron attribute as an option, styled as a Select2 dropdown. - Clicking the dropdown should trigger a list of the authorized values you created above. - Test that the search field at the top of the list works correctly to filter the results. - Test that any repeatable attribute field can be cloned by clicking the "Add" link, and that cloned fields can be removed using the "Delete" links. - Test that cloned fields remain in place after submitting the fitler form, and that any selected entry in a Select2 widget is preselected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice one.. this works great now. All works as expected, no QA script failures reported. Passing QA Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.06 Doesn't apply cleanly to 20.05, please rebase if needed. Created attachment 121393 [details] [review] Bug 16785: [20.05] Remove Autocomplete from overdues report filter This patch removes code and markup related to an autocomplete input field in the overdues report filter. The autocomplete was intended to enable easy entry of patron attributes, but it's simpler to use a Select2-styled <select> The patch removes circ/ypattrodue-attr-search-authvalue.pl, which was only used on this page and is now obsolete. To test, apply the patch and create at least one patron attribute type which is linked to an authorized value: - Administration -> Authorized values -> New category - Create a new category to test with - Add multiple authorized values under this category - Administration -> Patron attribute types -> New patron attribute type. - Create an attribute which is linked to the authorized value category you created AND which is marked "Searchable." - Go to Circulation -> Overdues. - In the sidebar filter you should see your patron attribute as an option, styled as a Select2 dropdown. - Clicking the dropdown should trigger a list of the authorized values you created above. - Test that the search field at the top of the list works correctly to filter the results. - Test that any repeatable attribute field can be cloned by clicking the "Add" link, and that cloned fields can be removed using the "Delete" links. - Test that cloned fields remain in place after submitting the fitler form, and that any selected entry in a Select2 widget is preselected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |